Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: 2.0.0
-
Component/s: ICE-Components
-
Labels:None
-
Environment:ICEfaces 2 panel position
Description
Saw this behaviour while testing in portlets. When the PanelPositioned component is initially rendered as a portlet, it looks fine. The first update after a drag renders out a comment that looks something like this:
<!-- 165 -->
The number is somewhat random but it remains rendered after the first update with only the number changing.
<!-- 165 -->
The number is somewhat random but it remains rendered after the first update with only the number changing.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [] | |
| Fix Version/s | 2.0.0 [ 10230 ] | |
| Assignee Priority | P2 | |
| Assignee | Deryk Sinotte [ deryk.sinotte ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #23290 | Thu Dec 02 17:03:20 MST 2010 | deryk.sinotte | |
| Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
|
Checked in a change that uses the createTextNodeUnescaped API to prevent escaping and displaying the comment.
Show
Deryk Sinotte
added a comment - Checked in a change that uses the createTextNodeUnescaped API to prevent escaping and displaying the comment.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P2 |
Not sure if this is confined to portlets or not but I found this in the PanelPositionedRenderer.encodeBegin method:
if (isChanged(facesContext))
{ // Force the re rendering of the entire component. This is due to a strange quick with positioned // panel. When an element is moved in the same list then it container element moves with it // When the update occurs the elements are replaced but because the containers have moved // then the result looks the same. (But a refresh shows otherwise) Node node = domContext.createTextNode( "<!-- " + (new Random().nextInt(1000)) + "-->"); root.appendChild(node); }It appears that the call to createTextNode is being escaped, leading to the comment actually being displayed.