ICEfaces
  1. ICEfaces
  2. ICE-6256

ACE components need to support f:params children

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEFaces ACE components
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      The LinkButton component needs to provide support for nested f:param children. In the case where the link is generated as an anchor, the necessary parameters need to be encoded as query string parameters, ?param1=value, when the link is rendered as a action event source, the parameters need to be included in the post parameters.

        Activity

        Greg Dick created issue -
        Greg Dick made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Assignee Greg Dick [ greg.dick ]
        Ken Fyten made changes -
        Assignee Priority P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23168 Thu Nov 18 17:00:47 MST 2010 greg.dick ICE-6256 Added tests for f:param support
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/web/commandLink.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23169 Thu Nov 18 17:08:51 MST 2010 greg.dick ICE-6256, ICE-6248 added support for target and f:param children
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/LinkButtonRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23170 Thu Nov 18 17:09:27 MST 2010 greg.dick ICE-6256 added methods for encoding parameters
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/Utils.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23171 Thu Nov 18 17:09:48 MST 2010 greg.dick ICE-6256 added methods for encoding parameters
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.linkbutton/linkbutton.js
        Hide
        Judy Guglielmin added a comment -

        mistakenly committed modifications for LinkButtonRenderer since org.icefaces.component.RendererBase was not included in the commit for f:param support (encoding of paramters), to ICE-6248. Should have been to this jira.

        Once this has been checked in, can use these modifications for PushButtonRenderer as well.

        Still outstanding is <ice:commandButton> from compat library of components. It does not have <f:param> support either.

        Show
        Judy Guglielmin added a comment - mistakenly committed modifications for LinkButtonRenderer since org.icefaces.component.RendererBase was not included in the commit for f:param support (encoding of paramters), to ICE-6248 . Should have been to this jira. Once this has been checked in, can use these modifications for PushButtonRenderer as well. Still outstanding is <ice:commandButton> from compat library of components. It does not have <f:param> support either.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23174 Fri Nov 19 23:23:36 MST 2010 greg.dick ICE-6256 fixed mistaken reference to RendererBase
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/LinkButtonRenderer.java
        Hide
        Ken Fyten added a comment -

        Need to review this technique and then apply to any other ace components that are missing f:param support.

        Show
        Ken Fyten added a comment - Need to review this technique and then apply to any other ace components that are missing f:param support.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Greg Dick [ greg.dick ] Judy Guglielmin [ judy.guglielmin ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Judy Guglielmin [ judy.guglielmin ] Greg Dick [ greg.dick ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23178 Mon Nov 22 12:46:50 MST 2010 greg.dick ICE-6256 handle the now possible no-params case.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.linkbutton/linkbutton.js
        Ken Fyten made changes -
        Summary LinkButton component needs to support f:params children ACE components need to support f:params children
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Salesforce Case []
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23257 Wed Dec 01 12:10:44 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/Utils.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23258 Wed Dec 01 12:11:07 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23259 Wed Dec 01 12:23:38 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/LinkButtonRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23260 Wed Dec 01 12:23:48 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23261 Wed Dec 01 12:24:10 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23262 Wed Dec 01 12:24:51 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.linkbutton/linkbutton.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23263 Wed Dec 01 12:25:15 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.pushbutton/pushbutton.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23264 Wed Dec 01 12:25:31 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23265 Wed Dec 01 12:25:47 MST 2010 greg.dick ICE-6256 supporting f:param in component
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.checkboxbutton/checkboxbutton.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23266 Wed Dec 01 12:27:13 MST 2010 greg.dick ICE-6256 supporting f:param in component, added support for encoding string array
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/JSONBuilder.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23271 Wed Dec 01 17:15:38 MST 2010 greg.dick ICE-6256 backing bean for f:Param tests
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/ace/test/src/org/icefaces/commandLink/fParamBean.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23272 Wed Dec 01 17:16:10 MST 2010 greg.dick ICE-6256 test page for f:param tests
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/ace/test/web/fparamTestPage.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23273 Wed Dec 01 17:16:59 MST 2010 greg.dick ICE-6256 test page for f:param tests
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/web/index.html
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23278 Thu Dec 02 11:41:49 MST 2010 greg.dick ICE-6256 moved params detection into onCheckedChange method
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.checkboxbutton/checkboxbutton.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23296 Fri Dec 03 09:49:24 MST 2010 greg.dick ICE-6256 removed submit button now that checkbox code fixed
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/web/fparamTestPage.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23297 Fri Dec 03 11:56:15 MST 2010 greg.dick ICE-6256 parameter values may be objects and need to be converted to String before adding to Array
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/utils/Utils.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23351 Tue Dec 07 11:24:01 MST 2010 greg.dick ICE-6256 Support for f:param children
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/resources/org.icefaces.component.sliderentry/slider.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23352 Tue Dec 07 11:24:58 MST 2010 greg.dick ICE-6256 Corrected spelling of postParameters argument
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/sliderentry/SliderEntryRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23353 Tue Dec 07 11:25:40 MST 2010 greg.dick ICE-6256 Added various tests for f:param testing of components
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/web/fparamTestPage.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23354 Tue Dec 07 11:26:07 MST 2010 greg.dick ICE-6256 various new methods for component f:param test support
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/src/org/icefaces/commandLink/fParamBean.java
        Hide
        Greg Dick added a comment -

        I have a solution in place for the linkButton, pushButton, checkbox, and slider. A test page exists in the ace-test application.

        The general approach consists of passing the values of any f:param children to the component javascript and then using the submit method with extra parameter support to send the parameters back to the server.

        Show
        Greg Dick added a comment - I have a solution in place for the linkButton, pushButton, checkbox, and slider. A test page exists in the ace-test application. The general approach consists of passing the values of any f:param children to the component javascript and then using the submit method with extra parameter support to send the parameters back to the server.
        Greg Dick made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1

          People

          • Assignee:
            Greg Dick
            Reporter:
            Greg Dick
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: