Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Fix Version/s: 2.0.0
-
Component/s: ACE-Components
-
Labels:None
-
Environment:IF 2 Adv. Comps.
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration
Description
Currently the CSS styling, classnames, and CSS files being used by the pushButton, checkboxButton, and linkButton are a bit-muddled with duplication and overlap. This is a result of each of these buttons originating from a single YUI button component.
To clean this up each button type should have it's own distinct CSS classnames and CSS files it references to avoid unintended overlap/influence between each component's styling, and also to optimize the CSS files being included so no duplicates are used.
To clean this up each button type should have it's own distinct CSS classnames and CSS files it references to avoid unintended overlap/influence between each component's styling, and also to optimize the CSS files being included so no duplicates are used.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [] | |
| Fix Version/s | 2.0.0 [ 10230 ] | |
| Affects | [Documentation (User Guide, Ref. Guide, etc.)] |
| Salesforce Case | [] | |
| Affects | [Documentation (User Guide, Ref. Guide, etc.)] | [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration] |
| Assignee Priority | P1 |
| Salesforce Case | [] | |
| Assignee | Arturo Zambrano [ artzambrano ] |
Also note that it's okay for the Rime and Sam skins for these buttons to use images to represent the button states, as one of the main reasons to use these buttons instead of say, h: or ice: commandButton, etc. is the image-skinning. We do not need these buttons to use default browser styling for the Rime skin.
Show
Ken Fyten
added a comment - Also note that it's okay for the Rime and Sam skins for these buttons to use images to represent the button states, as one of the main reasons to use these buttons instead of say, h: or ice: commandButton, etc. is the image-skinning. We do not need these buttons to use default browser styling for the Rime skin.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #23390 | Wed Dec 08 15:21:31 MST 2010 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/pushbutton/skins/sam/button.css
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #23411 | Thu Dec 09 01:00:04 MST 2010 | art.zambrano | |
| Files Changed | ||||
ADD
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/background-active.png
ADD
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/background-disabled.gif
ADD
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/background.png
MODIFY
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/linkbutton.css
ADD
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/background-highlight.png
ADD
/icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/linkbutton/skins/rime/background-focus.png
|
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Assignee Priority | P1 | |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
It also seems like the same CSS classes are reference/linked multiple times for each component. This needs to be cleaned up.