ICEfaces
  1. ICEfaces
  2. ICE-6207

ACE generator default javadocGet and javadocSet to tlddoc

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 3.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ACE

      Description

      When the @Property(javadocGet) field is not set, it's contents should default to include the tlddoc, if that was specified. Same for javadocSet. That way, IDEs will show the same documentation when editing .java files as they will when editing .xhtml files.

        Issue Links

          Activity

          Mark Collette created issue -
          Hide
          Mark Collette added a comment -

          Refer to ICE-6209. For javadocGet and javadocSet, append the tlddoc once it includes defaultValue.

          Show
          Mark Collette added a comment - Refer to ICE-6209 . For javadocGet and javadocSet, append the tlddoc once it includes defaultValue.
          Mark Collette made changes -
          Field Original Value New Value
          Link This issue depends on ICE-6209 [ ICE-6209 ]
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 2.0.0 [ 10230 ]
          Ken Fyten made changes -
          Salesforce Case []
          Assignee Greg Dick [ greg.dick ]
          Ken Fyten made changes -
          Assignee Priority P2
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #23448 Fri Dec 10 11:24:11 MST 2010 greg.dick ICE-6209, ICE-6207 Munging tlddoc and javadocGet/Set comments to have more content
          Files Changed
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/generator/xmlbuilder/TLDBuilder.java
          Hide
          Greg Dick added a comment -

          Resolved, although still needs to be tested.

          Show
          Greg Dick added a comment - Resolved, although still needs to be tested.
          Greg Dick made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Security Private [ 10001 ]
          Greg Dick made changes -
          Salesforce Case []
          Description When the @Component(javadocGet) field is not set, it's contents should default to include the tlddoc, if that was specified. Same for javadocSet. That way, IDEs will show the same documentation when editing .java files as they will when editing .xhtml files.
          When the @Property(javadocGet) field is not set, it's contents should default to include the tlddoc, if that was specified. Same for javadocSet. That way, IDEs will show the same documentation when editing .java files as they will when editing .xhtml files.
          Hide
          Ken Fyten added a comment -

          This change is breaking deployment to Jboss servers (see ICE-6173).

          We should revert this for 2.0.0.

          Show
          Ken Fyten added a comment - This change is breaking deployment to Jboss servers (see ICE-6173 ). We should revert this for 2.0.0.
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          ICEsoft Forum Reference http://www.icefaces.org/JForum/posts/list/18240.page#66312
          Salesforce Case []
          Ken Fyten made changes -
          Link This issue blocks ICE-6173 [ ICE-6173 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #23532 Wed Dec 15 09:56:45 MST 2010 greg.dick ICE-6207 Removed javadocSet/Get changes. Wrong place.
          Files Changed
          Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/generator/xmlbuilder/TLDBuilder.java
          Ken Fyten made changes -
          Fix Version/s 2.1 [ 10241 ]
          Fix Version/s 2.0.0 [ 10230 ]
          Assignee Priority P2
          Ken Fyten made changes -
          Salesforce Case []
          Assignee Greg Dick [ greg.dick ] Mark Collette [ mark.collette ]
          Ken Fyten made changes -
          Fix Version/s 3.1 [ 10312 ]
          Fix Version/s 3.0 [ 10241 ]
          Ken Fyten made changes -
          Fix Version/s 3.2 [ 10338 ]
          Fix Version/s 3.1 [ 10312 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #31705 Tue Oct 23 18:15:50 MDT 2012 art.zambrano ICE-6207 generator: added tlddoc contents to contents of javadoc for getter and setter methods, if javadocGet and javadocSet aren't explicitly specified in the @Property annotation
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/MetaContext.java
          Hide
          Arturo Zambrano added a comment - - edited

          Committed fix to trunk at revision 31705.

          Show
          Arturo Zambrano added a comment - - edited Committed fix to trunk at revision 31705.
          Migration made changes -
          Fix Version/s 3.3 [ 10370 ]
          Fix Version/s 3.2 [ 10338 ]
          Migration made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Mark Collette
              Reporter:
              Mark Collette
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: