ICEfaces
  1. ICEfaces
  2. ICE-6200

ACE fileEntry required

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta2
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ACE
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            The FileEntry required property is supported throught the FileEntry infrastructure, with the statuses etc., but is not actually enforced when required="true". Exactly what enforcement would require is not fully know. Perhaps calling FacesContext.validationFailed() would suffice. Additionally, FacesContext.renderResponse() might be necessary.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0.0 [ 10230 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.)]
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Priority P2
              Security Private [ 10001 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23611 Thu Dec 16 19:19:43 MST 2010 mark.collette ICE-6200 : ACE fileEntry required
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/fileentry/FileEntry.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/fileentry/FileEntryStatuses.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23612 Thu Dec 16 19:24:03 MST 2010 mark.collette ICE-6200 : ACE fileEntry required
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/test/web/fileEntry.xhtml
              Hide
              Permalink
              Mark Collette added a comment -

              Now the required property will be respected. Iif a non-single-submit and non-partial-submit form submit occurs, which executes the fileEntry component, and no file has been uploaded, it will check it's required property, and fail the form submission, and add a FacesMessage. The FacesMessage will first try to use the message format specified by the requiredMessage property, and if none is given, will use the message format from the application resource bundle, and if none is given, will use the message format from the ACE resource bundle. The message format has one parameter

              {0}

              in which the fileEntry component's label or clientId will go.

              Adding the basic functionality of required was straight forward, given ICE-6203 provided a default validation mechanism. The only challenge was in making the FileEntryStatuses.REQUIRED code for creating a FacesMessage, since it is a unique case, as it does not describe a FileInfo like most of the other cases.

              Test ui provided, in form17 of: icefaces2/ace/test/web/fileEntry.xhtml

              Component changes
              Subversion 23611

              Test app changes
              Subversion 23612

              Show
              Mark Collette added a comment - Now the required property will be respected. Iif a non-single-submit and non-partial-submit form submit occurs, which executes the fileEntry component, and no file has been uploaded, it will check it's required property, and fail the form submission, and add a FacesMessage. The FacesMessage will first try to use the message format specified by the requiredMessage property, and if none is given, will use the message format from the application resource bundle, and if none is given, will use the message format from the ACE resource bundle. The message format has one parameter {0} in which the fileEntry component's label or clientId will go. Adding the basic functionality of required was straight forward, given ICE-6203 provided a default validation mechanism. The only challenge was in making the FileEntryStatuses.REQUIRED code for creating a FacesMessage, since it is a unique case, as it does not describe a FileInfo like most of the other cases. Test ui provided, in form17 of: icefaces2/ace/test/web/fileEntry.xhtml Component changes Subversion 23611 Test app changes Subversion 23612
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Mark Collette
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: