ICEfaces
  1. ICEfaces
  2. ICE-6158

Project stage 'Development' interactions result in loss of CSS styling on page or DOM update to body

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta2
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 2, ACE component environment, PROJECT_STAGE='Development'.
    • Workaround Exists:
      Yes
    • Workaround Description:
      Workaround is to specify 'Production' project_stage.

      Description

      ACE: Validation failures when in project stage 'Development' result in loss of CSS styling on page.

      The style problem is not specific to tabSet, I have verified it by putting dataEntry on the same page. The CSS issue is due to the reason that in showcase web.xml we have project_stage set to development.

      <context-param>
      <param-name>javax.faces.PROJECT_STAGE</param-name>
      <param-value>Development</param-value>
      </context-param>

      It causes to add some fields in the body, which is resulting a body level update, that messing up css.

      Removing above param from web.xml fixes the app, but not a solution.

      So problem is when there is a body level update.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22828 Mon Oct 25 08:38:43 MDT 2010 ken.fyten ICE-6158: Set PROJECT_STAGE to 'Production' to avoid CSS styling loss on validation failure.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/ace/samples/showcase/src/main/webapp/WEB-INF/web.xml
        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0.0 [ 10230 ]
        Assignee Ted Goddard [ ted.goddard ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22844 Mon Oct 25 13:31:06 MDT 2010 ted.goddard always render container element for MessagesRenderer (ICE-6158)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/html_basic/MessagesRenderer.java
        Hide
        Ted Goddard added a comment -

        This div at the end of the body looks suspicious:

        <div id="javax_faces_developmentstage_messages"><ul id="javax_faces_developmentstage_messages" title="Project Stage[Development]: Unhandled Messages"></ul></div></body>

        Show
        Ted Goddard added a comment - This div at the end of the body looks suspicious: <div id="javax_faces_developmentstage_messages"><ul id="javax_faces_developmentstage_messages" title="Project Stage [Development] : Unhandled Messages"></ul></div></body>
        Hide
        Ted Goddard added a comment - - edited

        This is rendered by renderUnhandledMessages() in com/sun/faces/renderkit/RenderKitUtils.java

        but is being disabled by the following code in our custom MessagesRenderer:

        //only write it if messages exist
        if ("javax_faces_developmentstage_messages".equals(component.getId()))

        { return; }

        Code was added for ICE-5716

        Show
        Ted Goddard added a comment - - edited This is rendered by renderUnhandledMessages() in com/sun/faces/renderkit/RenderKitUtils.java but is being disabled by the following code in our custom MessagesRenderer: //only write it if messages exist if ("javax_faces_developmentstage_messages".equals(component.getId())) { return; } Code was added for ICE-5716
        Hide
        Ted Goddard added a comment -

        Original mojarra renderer optionally renders javax_faces_developmentstage_messages as above.

        Show
        Ted Goddard added a comment - Original mojarra renderer optionally renders javax_faces_developmentstage_messages as above.
        Ted Goddard made changes -
        Summary ACE: Validation failures when in project stage 'Development' result in loss of CSS styling on page Project stage 'Development' interactions result in loss of CSS styling on page or DOM update to body
        Salesforce Case []
        Hide
        Ted Goddard added a comment -

        component-showcase and ace-showcase tested on Internet Explorer with no style problems observed with the fix.

        Show
        Ted Goddard added a comment - component-showcase and ace-showcase tested on Internet Explorer with no style problems observed with the fix.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0-Beta2 [ 10242 ]
        Fix Version/s 2.0.0 [ 10230 ]
        Resolution Fixed [ 1 ]
        Hide
        Ted Goddard added a comment -

        The div for the MessagesRenderer is now always rendered in Development stage.

        Show
        Ted Goddard added a comment - The div for the MessagesRenderer is now always rendered in Development stage.
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Ted Goddard
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: