Details
-
Type: Bug
-
Status: Open
-
Priority: Major
-
Resolution: Unresolved
-
Affects Version/s: 1.8.2-EE-GA_P01
-
Fix Version/s: None
-
Component/s: Framework
-
Labels:None
-
Environment:ICEfaces
Description
SettableLocaleViewRoot is implemented by inspecting the stack to accept the locale only from certain callers:
public void setLocale(Locale locale) {
//ignore locale set by RestoreViewPhase since it is using the first locale in the Accept-Language list,
//instead it should calculate the locale
StackTraceElement[] ste = (new RuntimeException()).getStackTrace();
This approach is performance intensive and should be revised.
public void setLocale(Locale locale) {
//ignore locale set by RestoreViewPhase since it is using the first locale in the Accept-Language list,
//instead it should calculate the locale
StackTraceElement[] ste = (new RuntimeException()).getStackTrace();
This approach is performance intensive and should be revised.
Since we don't have a firm understanding of the regression risk associated with removing this logic, and that it would require some substantial effort to create reasonable tests to ascertain the actual risk, and also that there is no obvious way to implement the existing logic using a more performant technique, I am moving this out of P02 for time/resource constraint reasons.