ICEfaces
  1. ICEfaces
  2. ICE-6141

Use Resource API to calculate ICEpush listen URL

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            The current template mechanism for calculating the "listen.icepush" URL does not handle all cases well so it has been re-implemented to use the Resource API more directly.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22699 Wed Oct 20 12:49:47 MDT 2010 ted.goddard use Resource API to determine listen.icepush URL (ICE-6141)
              Files Changed
              Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushListenResource.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22701 Wed Oct 20 13:20:21 MDT 2010 deryk.sinotte ICE-6141: ensure startElement is called before writeAttribute
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
              Ted Goddard created issue -
              Hide
              Permalink
              Ted Goddard added a comment -

              Please resolve this issue if the Portlet tests are successful.

              Show
              Ted Goddard added a comment - Please resolve this issue if the Portlet tests are successful.
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Checked in an adjustment to the BridgeSetup.GenericScriptWriter where writing stuff to the writer is sensitive to the order. The startElement must be called before writeAttribute. In our case:

              public void encode(ResponseWriter writer, FacesContext context) throws IOException

              { String clientID = getClientId(context); //Exchange the position of the next 2 lines writer.writeAttribute("id", clientID, null); writer.startElement("script", this); //define potential script entries writer.writeAttribute("src", script, null); writer.writeAttribute("type", "text/javascript" , null); writer.endElement("script"); }
              Show
              Deryk Sinotte added a comment - Checked in an adjustment to the BridgeSetup.GenericScriptWriter where writing stuff to the writer is sensitive to the order. The startElement must be called before writeAttribute. In our case: public void encode(ResponseWriter writer, FacesContext context) throws IOException { String clientID = getClientId(context); //Exchange the position of the next 2 lines writer.writeAttribute("id", clientID, null); writer.startElement("script", this); //define potential script entries writer.writeAttribute("src", script, null); writer.writeAttribute("type", "text/javascript" , null); writer.endElement("script"); }
              Ted Goddard made changes -
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22759 Thu Oct 21 14:03:09 MDT 2010 ted.goddard avoid caching listen.icepush resource (ICE-6141)
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
              Deryk Sinotte made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: