ICEfaces
  1. ICEfaces
  2. ICE-6109

sparkle generator Property name field

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta2
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            sparkle

            Description

            In org.icefaces.component.baseMeta.UIMessageMeta, the forValue property is called "forValue" when it should be called "for", but can't because that's a Java reserved word. Facet solves this problem by having a name field. Property should copy the name field concept, and the generator should be modified to support it, which would allow:

            @Property(name="for")
            private String forValue;

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Salesforce Case []
              Security Private [ 10001 ]
              Mark Collette made changes -
              Salesforce Case []
              Affects Version/s 2.0-Beta2 [ 10242 ]
              Affects Version/s 2.0-Beta1 [ 10231 ]
              Hide
              Permalink
              Mark Collette added a comment -

              tabSetController has a For property

              Show
              Mark Collette added a comment - tabSetController has a For property
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Component/s ACE-Components [ 10050 ]
              Component/s Components [ 10012 ]
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Greg Dick [ greg.dick ]
              Ken Fyten made changes -
              Assignee Priority P2
              Hide
              Permalink
              Mark Collette added a comment -

              We need to generate something similar to what JSF uses in it's own components:

              public class HtmlOutputLabel extends javax.faces.component.UIOutput implements ClientBehaviorHolder {
                 ...
                 protected enum PropertyKeys

              {        accesskey,        dir,        escape,        forVal("for"), <<=====         ...    }

                 public java.lang.String getFor()

              {        return (java.lang.String) getStateHelper().eval(PropertyKeys.forVal);    }

                 public void setFor(java.lang.String _for)

              {        getStateHelper().put(PropertyKeys.forVal, _for);    }

              }

              Show
              Mark Collette added a comment - We need to generate something similar to what JSF uses in it's own components: public class HtmlOutputLabel extends javax.faces.component.UIOutput implements ClientBehaviorHolder {    ...    protected enum PropertyKeys {        accesskey,        dir,        escape,        forVal("for"), <<=====         ...    }    public java.lang.String getFor() {        return (java.lang.String) getStateHelper().eval(PropertyKeys.forVal);    }    public void setFor(java.lang.String _for) {        getStateHelper().put(PropertyKeys.forVal, _for);    } }
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23394 Wed Dec 08 15:51:45 MST 2010 greg.dick ICE-6109 Added support for naming properties
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/component/annotation/Property.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/generator/utils/PropertyValues.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/generator/context/ComponentContext.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/generator/src/org/icefaces/generator/artifacts/ComponentArtifact.java
              Hide
              Permalink
              Greg Dick added a comment -

              Fixed

              Show
              Greg Dick added a comment - Fixed
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: