ICEfaces
  1. ICEfaces
  2. ICE-6098

Fine-grained StateManager configuration with TouchSession Filter

    Details

    • Type: Task Task
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces 1.8

      Description


      Both the TouchSession filter and Fine-grained StateManager is required in the same patch.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22582 Fri Oct 08 13:20:46 MDT 2010 ted.goddard combine TouchSession and StateManger (ICE-6098)
        Files Changed
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098
        Ted Goddard created issue -
        Ted Goddard made changes -
        Field Original Value New Value
        Salesforce Case []
        Assignee Ted Goddard [ ted.goddard ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22584 Fri Oct 08 15:44:46 MDT 2010 ted.goddard isRenderedOnUserRole optimization (ICE-6098)
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/component/src/com/icesoft/faces/component/ext/taglib/Util.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22585 Fri Oct 08 15:45:24 MDT 2010 ted.goddard fine-grained StateManager (ICE-6098)
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/build.xml
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/application/ViewRootStateManagerImpl.java
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/conf/META-INF/include.tld
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/application/OverridePhaseListener.java
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/core/conf/META-INF/core.taglib.xml
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/build.xml
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/conf/just-ice/faces-config.xml
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/application/SingleCopyStateManagerImpl.java
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/webapp/ViewNumberTag.java
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/src/com/icesoft/applications/faces/auctionMonitor/StateManagerFilter.java
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/web/stockMonitor.jspx
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/src/com/icesoft/applications/faces/auctionMonitor/beans/AuctionMonitorItemBean.java
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/src/com/icesoft/applications/faces/auctionMonitor/beans/UserBean.java
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/config/web.sunri.icefaces.ce.xml
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/samples/auctionMonitor/web/WEB-INF/faces-config.xml
        Commit graph ADD /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/renderkit/ViewNumberRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22586 Fri Oct 08 15:55:17 MDT 2010 ted.goddard patch revision (ICE-6098)
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/application/ProductInfo.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22587 Fri Oct 08 16:13:16 MDT 2010 ted.goddard patch revision (ICE-6098)
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/conf/com/icesoft/faces/application/ProductInfo.java
        Hide
        Ted Goddard added a comment - - edited
        Show
        Ted Goddard added a comment - - edited Patch source tree: http://anonsvn.icefaces.org/repo/icefaces/scratchpads/patches/ICE-6098
        Ted Goddard made changes -
        Salesforce Case []
        Ted Goddard made changes -
        Attachment Patch-ICE-6098.zip [ 12604 ]
        Ted Goddard made changes -
        Salesforce Case []
        Hide
        Ted Goddard added a comment -

        .jar files built with this patch have been compared with the previously used 1.8.0:

        No significant differences in icefaces-comps.jar

        > diff -rq svn/icefaces-comps-javap/ sa/icefaces-comps-javap/
        Files svn/icefaces-comps-javap/META-INF/MANIFEST.MF and sa/icefaces-comps-javap/META-INF/MANIFEST.MF differ

        • minor manifest difference

        >diff -rq svn/just-ice-javap/ sa/just-ice-javap/
        Only in svn/just-ice-javap/com/icesoft/faces/application: OverridePhaseListener.javap

        • expected new patch class

        Files svn/just-ice-javap/com/icesoft/faces/application/ProductInfo.javap and sa/just-ice-javap/com/icesoft/faces/application/ProductInfo.javap differ

        • expected patch version string difference

        Files svn/just-ice-javap/com/icesoft/faces/application/SingleCopyStateManagerImpl.javap and sa/just-ice-javap/com/icesoft/faces/application/SingleCopyStateManagerImpl.javap differ

        • expected patch StateManager difference

        Files svn/just-ice-javap/com/icesoft/faces/application/ViewRootStateManagerImpl.javap and sa/just-ice-javap/com/icesoft/faces/application/ViewRootStateManagerImpl.javap differ

        • expected patch StateManager difference

        Only in svn/just-ice-javap/com/icesoft/faces/renderkit: ViewNumberRenderer.javap

        • expected new patch class

        Only in svn/just-ice-javap/com/icesoft/faces/webapp: ViewNumberTag.javap

        • expected new patch class

        Files svn/just-ice-javap/com/icesoft/net/messaging/jms/JMSAdapter.javap and sa/just-ice-javap/com/icesoft/net/messaging/jms/JMSAdapter.javap differ
        Files svn/just-ice-javap/com/icesoft/net/messaging/jms/JMSSubscriberConnection.javap and sa/just-ice-javap/com/icesoft/net/messaging/jms/JMSSubscriberConnection.javap differ

        • classes used by Enterprise Push Server only; not exercised in the application

        Only in svn/just-ice-javap/META-INF: core.taglib.xml

        • expected new patch class

        Files svn/just-ice-javap/META-INF/faces-config.xml and sa/just-ice-javap/META-INF/faces-config.xml differ

        • expected modification to support patch ViewNumber component

        Files svn/just-ice-javap/META-INF/include.tld and sa/just-ice-javap/META-INF/include.tld differ

        • expected modification to support patch ViewNumber component

        Files svn/just-ice-javap/META-INF/MANIFEST.MF and sa/just-ice-javap/META-INF/MANIFEST.MF differ

        • minor manifest difference

        (Class files were dumped to decompiled text bytecode for comparison:

        /usr/local/jdk1.5.0_06/bin/javap -c "$

        {1%%.class}" >"${1%%.class}

        ".javap

        and this was evaluated recursively for "svn" (patch checkout ICE-6098) and "sa" (previous .jars used in production))

        Show
        Ted Goddard added a comment - .jar files built with this patch have been compared with the previously used 1.8.0: No significant differences in icefaces-comps.jar > diff -rq svn/icefaces-comps-javap/ sa/icefaces-comps-javap/ Files svn/icefaces-comps-javap/META-INF/MANIFEST.MF and sa/icefaces-comps-javap/META-INF/MANIFEST.MF differ minor manifest difference >diff -rq svn/just-ice-javap/ sa/just-ice-javap/ Only in svn/just-ice-javap/com/icesoft/faces/application: OverridePhaseListener.javap expected new patch class Files svn/just-ice-javap/com/icesoft/faces/application/ProductInfo.javap and sa/just-ice-javap/com/icesoft/faces/application/ProductInfo.javap differ expected patch version string difference Files svn/just-ice-javap/com/icesoft/faces/application/SingleCopyStateManagerImpl.javap and sa/just-ice-javap/com/icesoft/faces/application/SingleCopyStateManagerImpl.javap differ expected patch StateManager difference Files svn/just-ice-javap/com/icesoft/faces/application/ViewRootStateManagerImpl.javap and sa/just-ice-javap/com/icesoft/faces/application/ViewRootStateManagerImpl.javap differ expected patch StateManager difference Only in svn/just-ice-javap/com/icesoft/faces/renderkit: ViewNumberRenderer.javap expected new patch class Only in svn/just-ice-javap/com/icesoft/faces/webapp: ViewNumberTag.javap expected new patch class Files svn/just-ice-javap/com/icesoft/net/messaging/jms/JMSAdapter.javap and sa/just-ice-javap/com/icesoft/net/messaging/jms/JMSAdapter.javap differ Files svn/just-ice-javap/com/icesoft/net/messaging/jms/JMSSubscriberConnection.javap and sa/just-ice-javap/com/icesoft/net/messaging/jms/JMSSubscriberConnection.javap differ classes used by Enterprise Push Server only; not exercised in the application Only in svn/just-ice-javap/META-INF: core.taglib.xml expected new patch class Files svn/just-ice-javap/META-INF/faces-config.xml and sa/just-ice-javap/META-INF/faces-config.xml differ expected modification to support patch ViewNumber component Files svn/just-ice-javap/META-INF/include.tld and sa/just-ice-javap/META-INF/include.tld differ expected modification to support patch ViewNumber component Files svn/just-ice-javap/META-INF/MANIFEST.MF and sa/just-ice-javap/META-INF/MANIFEST.MF differ minor manifest difference (Class files were dumped to decompiled text bytecode for comparison: /usr/local/jdk1.5.0_06/bin/javap -c "$ {1%%.class}" >"${1%%.class} ".javap and this was evaluated recursively for "svn" (patch checkout ICE-6098 ) and "sa" (previous .jars used in production))
        Hide
        Ted Goddard added a comment -

        Attached new version of the patch compiled with JDK 1.5 on linux. Some differences in the way that inner classes were compiled were observed in the previous binary compiled with JDK 1.6 (but with JDK 1.4 javac target) affected the strict layout of the bytecode. It is not believed that these differences affected behavior in any way, however.

        Show
        Ted Goddard added a comment - Attached new version of the patch compiled with JDK 1.5 on linux. Some differences in the way that inner classes were compiled were observed in the previous binary compiled with JDK 1.6 (but with JDK 1.4 javac target) affected the strict layout of the bytecode. It is not believed that these differences affected behavior in any way, however.
        Ted Goddard made changes -
        Attachment Patch-ICE-6098-jdk15.zip [ 12606 ]
        Hide
        Ted Goddard added a comment -

        Patch complete.

        Show
        Ted Goddard added a comment - Patch complete.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23305 Mon Dec 06 09:49:47 MST 2010 ted.goddard simple concurrentDOMViews setting (ICE-6098)
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/patches/ICE-6098/icefaces/core/src/com/icesoft/faces/renderkit/ViewNumberRenderer.java
        Hide
        Ted Goddard added a comment -

        just-ice.jar with concurrentDOMViews for ViewNumberRenderer.

        Show
        Ted Goddard added a comment - just-ice.jar with concurrentDOMViews for ViewNumberRenderer.
        Ted Goddard made changes -
        Attachment just-ice.jar [ 12733 ]
        Ted Goddard made changes -
        Attachment just-ice-20101214.jar [ 12754 ]
        Hide
        Ted Goddard added a comment -

        Equivalent logging added to ICE-5452 branch.

        Show
        Ted Goddard added a comment - Equivalent logging added to ICE-5452 branch.
        Ted Goddard made changes -
        Attachment just-ice-5452.jar [ 12758 ]
        Hide
        Ted Goddard added a comment -

        org.icefaces.strictSessionTimeout FALSE setting allowed

        Show
        Ted Goddard added a comment - org.icefaces.strictSessionTimeout FALSE setting allowed
        Ted Goddard made changes -
        Attachment just-ice-20101216.jar [ 12770 ]
        Hide
        Ted Goddard added a comment -

        Setting is now supported which disables ICEfaces session monitor and invalidation:

        <context-param>
        <param-name>org.icefaces.strictSessionTimeout</param-name>
        <param-value>false</param-value>
        </context-param>

        Show
        Ted Goddard added a comment - Setting is now supported which disables ICEfaces session monitor and invalidation: <context-param> <param-name>org.icefaces.strictSessionTimeout</param-name> <param-value>false</param-value> </context-param>
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Ted Goddard added a comment -

        Re-opening to continue investigation.

        Show
        Ted Goddard added a comment - Re-opening to continue investigation.
        Ted Goddard made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Ted Goddard added a comment -

        strictSessionTimeout now avoids any call to setMaxInactiveInterval().

        Show
        Ted Goddard added a comment - strictSessionTimeout now avoids any call to setMaxInactiveInterval().
        Ted Goddard made changes -
        Attachment just-ice-20110107.jar [ 12796 ]
        Ken Fyten made changes -
        Assignee Ted Goddard [ ted.goddard ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: