ICEfaces
  1. ICEfaces
  2. ICE-6069

Refactor auction demo to use JSF/ICEFaces 2.0 best practices

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta1
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      JSF and ICEfaces 2.0

      Description

      Clean up and simplify the auction example that is shipped in the /samples folder. The original auction monitor was writing over 5 years ago, long before we established patterns of best practises and before Facelets and other JSF tools became available. The objective of this "improvement" is to simplify the auction sample using the latest JSF 2.0 and ICEfaces 2.0 coding standards. The auction example differs from the auctionMonitor example in that it doesn't use ICEfaces components just standard JSF 2.0 and ICEfaces 2.0 direct-to-dom.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22562 Thu Oct 07 13:46:07 MDT 2010 patrick.corless ICE-6069 tweaked bid validator and removed the logic that detects a push request instead opting for a per request refresh.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction/view/resources/messages.properties
        Commit graph DEL /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/PushDataRefreshListener.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/impl/AuctionServiceImpl.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/auction.xhtml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/AuctionController.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/auction_styles.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators/BidValidator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/DataRefreshListener.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22466 Wed Sep 29 14:56:38 MDT 2010 deryk.sinotte ICE-6069: adjust check for submit type to handle request parameter values
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/PushDataRefreshListener.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22453 Tue Sep 28 14:10:38 MDT 2010 patrick.corless ICE-6069 switched the default interval to 1 sec. but is configurable in the web.xml via org.icefaces.sample.auction.interval context param.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF/web.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22451 Tue Sep 28 14:06:40 MDT 2010 patrick.corless ICE-6069 added code to take advantage of the new request param ice.submit.type=ice.push. Also tweaked the bid validator expiry time convertor for a few feature request and bugs. Finally switched the default interval to 1 sec. but is configurable in the web.xml via org.icefaces.sample.auction.interval context param.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/converters/ExpiryDateConverter.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/PushDataRefreshListener.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans/AuctionBean.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF/web.xml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/auction.xhtml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/AuctionController.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators/BidValidator.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/ParameterNames.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22446 Tue Sep 28 11:20:02 MDT 2010 patrick.corless ICE-6069 addition of detailed commends, internationalization and some code clean up.
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/BeanNames.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction/view
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/build.xml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction/view/resources/messages.properties
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/auction.xhtml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/AuctionController.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction/view/resources/messages_en.properties
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/converters/ExpiryDateConverter.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF/faces-config.xml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/components/ColumnSorter/ColumnSortCommand.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources/org/icefaces/demo/auction/view/resources
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators/BidValidator.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22443 Tue Sep 28 07:12:00 MDT 2010 patrick.corless ICE-6069 cleaned up javadoc and removed the remaining 1.6 @override calls. Cleaned up code. Just internationalization left.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/BeanNames.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemPriceComparator.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/demo_template.css
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/AuctionService.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/impl/AuctionServiceImpl.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/beans/AuctionItem.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF/web.xml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/auction.xhtml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/util/FacesUtils.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/AuctionController.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/components/columnSorter.xhtml
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/ParameterNames.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemExpiresComparator.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/converters/ExpiryDateConverter.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemBidsComparator.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemNameComparator.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/PushDataRefreshListener.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans/AuctionBean.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans/AuctionItemBean.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/components/ColumnSorter/ColumnSortCommand.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators/BidValidator.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22432 Mon Sep 27 10:35:35 MDT 2010 patrick.corless ICE-6069 removed 1.5 lang level @override on an interface.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/AbstractItemComparator.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22426 Sun Sep 26 11:08:58 MDT 2010 patrick.corless ICE-6069 initial check in of simplified auction example. still have to complete commenting the classes and jsf.
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/button_triangle_open.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/expanded_false.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/ascending_arrow_false.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/build.xml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/demo_template.css
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/util
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_4.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/banner_bg.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_5.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/beans/AuctionItem.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/util/FacesUtils.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/templates
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/banner_logo.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/noimage.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/bgslice_footer.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/AbstractItemComparator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/PushDataRefreshListener.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/favicon.ico
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/components/ColumnSorter/ColumnSortCommand.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/index.jsp
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemPriceComparator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_0.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/AuctionService.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/components
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/footer_faces.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/iceskate.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_2.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/button_bid.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/icesailor.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/components/ColumnSorter
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/auction.xhtml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/WEB-INF/web.xml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/icecar.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/ascending_arrow_true.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/button_bid_accept.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/impl
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/blue-fade-bkgnd.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans/AuctionItemBean.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/BeanNames.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/converters
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/templates/icesoft-sampleapp-1.xhtml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/components
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/components/columnSorter.xhtml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemExpiresComparator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/converters/ExpiryDateConverter.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/resources
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemBidsComparator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/Comparator/ItemNameComparator.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/beans
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/expanded_true.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/beans/AuctionBean.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_1.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/IntervalPushRenderer.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/bgslice_footer.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/button_triangle_close.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/services/impl/AuctionServiceImpl.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_7.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/button_bid_decline.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/controllers/AuctionController.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_3.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/names/ParameterNames.java
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/icebreaker.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/banner_hdr_auction.jpg
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/images/time_left_6.gif
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/pom.xml
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/webapp/resources/css/auction_styles.css
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces
        Commit graph ADD /icefaces2/trunk/icefaces/samples/auction/src/main/java/org/icefaces/demo/auction/view/validators/BidValidator.java

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: