ICEfaces
  1. ICEfaces
  2. ICE-6067

CoreComponentUtils.findComponent(UIComponent,String) endsWith

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            icefaces2

            Description

            CoreComponentUtils.findComponent(UIComponent uiComponent, String componentId) has a bug where the id matching uses String.endsWith, which erroneously matches components when a component id ends with a substring that is equal to the id of another component. A concrete example is in the forum post.

                       } else if (child.getId() != null && componentId.endsWith(child.getId())) {

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Assignee Priority P1
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22444 Tue Sep 28 09:16:07 MDT 2010 deryk.sinotte ICE-6067: changed string check from endsWith to equals to avoid matching partially matched ids
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/util/CoreComponentUtils.java
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Source and pre-built .war file for Glassfish 3 that exercises findComponent in UIData scenarios.

              Show
              Deryk Sinotte added a comment - Source and pre-built .war file for Glassfish 3 that exercises findComponent in UIData scenarios.
              Deryk Sinotte made changes -
              Attachment findcomp.zip [ 12577 ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Changed CoreComponentUtils from:

              } else if (child.getId() != null && componentId.endsWith(child.getId()))

              { to }

              else if (child.getId() != null && componentId.equals(child.getId())) {

              I've attached the test case that I used to verify the change fixes the original problem with the datapaginator id as well as a couple of other scenarios that might have been impacted by the change.

              Show
              Deryk Sinotte added a comment - Changed CoreComponentUtils from: } else if (child.getId() != null && componentId.endsWith(child.getId())) { to } else if (child.getId() != null && componentId.equals(child.getId())) { I've attached the test case that I used to verify the change fixes the original problem with the datapaginator id as well as a couple of other scenarios that might have been impacted by the change.
              Deryk Sinotte made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: