ICEfaces
  1. ICEfaces
  2. ICE-6044

getRemoteAddr() method is not available for PortletRequests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta1
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces 2 portlets portal

      Description

      In the ThreadBlockingAdaptingServlet.blockUntilRespond() method, if no response is made, we release the semaphore and log a warning message. That message includes a call to the request.getRemoteAddr() method. However, if the request is a PortletRequest (rather than a ServletRequest), that method is not available and the logging call throws and exception.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22339 Tue Sep 14 13:28:27 MDT 2010 deryk.sinotte ICE-6044: getRemoteAddress is UnsupportedOperation in portlet environment
        Files Changed
        Commit graph MODIFY /scratchpads/snowplow/core/src/main/java/org/icepush/servlet/ThreadBlockingAdaptingServlet.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22340 Tue Sep 14 13:30:26 MDT 2010 deryk.sinotte ICE-6044: use "unknown" String for remoteAddress when in portlet environment
        Files Changed
        Commit graph MODIFY /scratchpads/snowplow/core/src/main/java/org/icepush/servlet/ThreadBlockingAdaptingServlet.java
        Deryk Sinotte created issue -
        Deryk Sinotte made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0-Beta2 [ 10242 ]
        Assignee Priority P2
        Assignee Deryk Sinotte [ deryk.sinotte ]
        Hide
        Deryk Sinotte added a comment -

        Adjusted the class to check the type of the request and use an "unknown" value if running in a portlet environment.

        Show
        Deryk Sinotte added a comment - Adjusted the class to check the type of the request and use an "unknown" value if running in a portlet environment.
        Deryk Sinotte made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: