ICEfaces
  1. ICEfaces
  2. ICE-6007

ACE: Fix 'Rime' skin issues with TabSet component

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 2 Sparkle component

            Description

            The new Sparkle tab needs to have a rime skin added for it. The rime skin should be based off the existing 1.8 tabset rime theme images, etc., although they will need to be re-interrpreted or translated as required for the new component.

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Assignee Priority P1
              Assignee Ken Fyten [ ken.fyten ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Initial version is in place but has numerous issues:

              • Vertical orientation tab labels don't size correctly.
              • Lack of borders
              • Tab shading doesn't really match rime tab
              Show
              Ken Fyten added a comment - Initial version is in place but has numerous issues: Vertical orientation tab labels don't size correctly. Lack of borders Tab shading doesn't really match rime tab
              Ken Fyten made changes -
              Summary Sparkle: Add 'rime' skin to tabPanel component. ACE: Add 'rime' skin to TabSet component.
              Issue Type Task [ 3 ] Improvement [ 4 ]
              Salesforce Case []
              Component/s ACE-Components [ 10050 ]
              Component/s Components [ 10012 ]
              Fix Version/s 2.0.0 [ 10230 ]
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Assignee Priority P1
              Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
              Ken Fyten made changes -
              Summary ACE: Add 'rime' skin to TabSet component. ACE: Fix 'Rime' skin issues with TabSet component
              Salesforce Case []
              Assignee Priority P1
              Hide
              Permalink
              Ken Fyten added a comment -

              It seems that the current Rime CSS is missing some of the req. CSS styling in order for the tabset to layout correctly. I would suggest an approach where the Sam skin CSS is copied, and then tweaked to use Rime fonts, images, etc. as req. while maintaining the correct layout behaviors.

              Show
              Ken Fyten added a comment - It seems that the current Rime CSS is missing some of the req. CSS styling in order for the tabset to layout correctly. I would suggest an approach where the Sam skin CSS is copied, and then tweaked to use Rime fonts, images, etc. as req. while maintaining the correct layout behaviors.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23298 Fri Dec 03 17:30:53 MST 2010 yip.ng ICE-6007: ACE: Fix 'Rime' skin issues with TabSet component.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/samples/showcase/src/main/webapp/css/cssLayout.css
              Hide
              Permalink
              yip.ng added a comment -

              Sam skin copied.

              Border added.

              Tab content background uses color (unlike showcase 1.8, which uses background image) Therefore no gradual shading.

              Tab label widths upset by the addition of images in rime theme.

              Show
              yip.ng added a comment - Sam skin copied. Border added. Tab content background uses color (unlike showcase 1.8, which uses background image) Therefore no gradual shading. Tab label widths upset by the addition of images in rime theme.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23309 Mon Dec 06 14:38:07 MST 2010 yip.ng ICE-6007: ACE: Fix 'Rime' skin issues with TabSet component.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23310 Mon Dec 06 14:45:49 MST 2010 yip.ng ICE-6007: ACE: Fix 'Rime' skin issues with TabSet component.
              Files Changed
              Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/contentContainer_bg.gif
              Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid.gif
              Commit graph ADD /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid_off.gif
              Hide
              Permalink
              yip.ng added a comment -

              Revision: 23310

              Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid.gif
              Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid_off.gif
              Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/contentContainer_bg.gif

              Revision: 23309

              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css

              Revision: 23298

              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              Modified : /icefaces2/trunk/icefaces/ace/samples/showcase/src/main/webapp/css/cssLayout.css

              Show
              yip.ng added a comment - Revision: 23310 Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid.gif Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid_off.gif Added : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/contentContainer_bg.gif Revision: 23309 Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css Revision: 23298 Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css Modified : /icefaces2/trunk/icefaces/ace/samples/showcase/src/main/webapp/css/cssLayout.css
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              Seeing the following errors loading Rime images for TabSet in server logs:

              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png.
              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png.
              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png.
              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background.png.
              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background-selected-1.png.
              Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource
              WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background-selected-2.png.

              Show
              Ken Fyten added a comment - - edited Seeing the following errors loading Rime images for TabSet in server logs: Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png. Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png. Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins//Users/Ken/Code/svn/icefaces2/icefaces/ace/component/build/assets/skins/sam/sprite.png. Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background.png. Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background-selected-1.png. Dec 8, 2010 6:06:39 PM com.sun.faces.application.resource.ResourceHandlerImpl logMissingResource WARNING: JSF1064: Unable to find or serve resource, org.icefaces.component.skins/rime/tabset/background-selected-2.png.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Ken Fyten added a comment - - edited

              Art, please review and fix the resource loading issues above.

              Show
              Ken Fyten added a comment - - edited Art, please review and fix the resource loading issues above.
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Yip Ng [ yip.ng ] Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23427 Thu Dec 09 14:38:48 MST 2010 ken.fyten ICE-6007: Removed extraneous duplication of styles that seem to have been originally copied from the ../skins/sam_renamed/tabview-skin.css.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23430 Thu Dec 09 15:12:57 MST 2010 ken.fyten ICE-6007: Increased size of images to match Sam skin ones for better scaling.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid.gif
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/Tab_MidMid_off.gif
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Ken Fyten [ ken.fyten ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Fixed the resource loading errors above by cleaning up the Rime tabset.css to remove some image references that were copied in from the Sam stylesheet.

              Show
              Ken Fyten added a comment - Fixed the resource loading errors above by cleaning up the Rime tabset.css to remove some image references that were copied in from the Sam stylesheet.
              Hide
              Permalink
              Ken Fyten added a comment -

              Also increased the size of the tab background images to match those in Sam and scale better when viewed in multi-row left or right orientation.

              Show
              Ken Fyten added a comment - Also increased the size of the tab background images to match those in Sam and scale better when viewed in multi-row left or right orientation.
              Hide
              Permalink
              Ken Fyten added a comment -

              Still an issue with the selected-tab having a border between the tab and tab panel when orientation is bottom, left, or right.

              Show
              Ken Fyten added a comment - Still an issue with the selected-tab having a border between the tab and tab panel when orientation is bottom, left, or right.
              Ken Fyten made changes -
              Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23499 Mon Dec 13 16:03:33 MST 2010 yip.ng ICE-6007: ACE: Fix 'Rime' skin issues with TabSet component.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              Hide
              Permalink
              yip.ng added a comment -

              Revision: 23499

              Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css

              Show
              yip.ng added a comment - Revision: 23499 Modified : /icefaces2/trunk/icefaces/ace/component/src/org/icefaces/component/tab/skins/rime/tabset.css
              yip.ng made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: