ICEfaces
  1. ICEfaces
  2. ICE-5994

Add a tabindex attribute to the panelTabSet

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA_P01
    • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      Feature Request: Add a tabindex attribute to the <ice:panelTabSet/> component.

      This will allow a user to tab into a tab set when there are other form inputs on a page with their tab indexes set. Once the tab set has focus a user can use katboard navigation to move through and select desired tabs.

      Currently if there are other form inputs that have tab indexes set the tab set gets focus after the last index is reached which disrupts smooth form tabbing.

      Here is some sample code that displays the issue:

                  <ice:form>
                      <ice:panelGrid columns="2">
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="1"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="2"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="3"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="4"/>
                      </ice:panelGrid>
                      <ice:panelTabSet>
                          <ice:panelTab>
                              <f:facet name="label">
                                  <ice:panelGroup >
                                      <ice:outputText value="Tab 1"/>
                                  </ice:panelGroup>
                              </f:facet>
                              <ice:outputText value="Tab 1 Contents"/>
                          </ice:panelTab>
                          <ice:panelTab>
                              <f:facet name="label">
                                  <ice:panelGroup>
                                      <ice:outputText value="Tab 2"/>
                                  </ice:panelGroup>
                              </f:facet>
                              <ice:outputText value="Tab 2 Contents"/>
                          </ice:panelTab>
                          <ice:panelTab>
                              <f:facet name="label">
                                  <ice:panelGroup>
                                      <ice:outputText value="Tab 3"/>
                                  </ice:panelGroup>
                              </f:facet>
                              <ice:outputText value="Tab 3 Contents"/>
                          </ice:panelTab>
                      </ice:panelTabSet>
                      <ice:panelGrid columns="2">
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="6"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="7"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="8"/>
                          <ice:outputText value="Input:"/>
                          <ice:inputText tabindex="9"/>
                      </ice:panelGrid>
                  </ice:form>

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Salesforce Case [5007000000D5KoO]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Assignee Priority P2
        Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23021 Wed Nov 03 12:41:58 MDT 2010 yip.ng ICE-5994: Add a tabindex attribute to the panelTabSet.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23022 Wed Nov 03 12:43:34 MDT 2010 yip.ng ICE-5994: Add a tabindex attribute to the panelTabSet.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23023 Wed Nov 03 13:36:21 MDT 2010 yip.ng ICE-5994: Add a tabindex attribute to the panelTabSet.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23024 Wed Nov 03 13:37:35 MDT 2010 yip.ng ICE-5994: Add a tabindex attribute to the panelTabSet.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSet.java
        Hide
        yip.ng added a comment -

        Revision: 23021


        Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        Modified : /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml

        Revision: 23022


        Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
        Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java

        Show
        yip.ng added a comment - Revision: 23021 Modified : /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java Modified : /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml Revision: 23022 Modified : /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml Modified : /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Fix Version/s 1.8.3 [ 10211 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2

          People

          • Assignee:
            yip.ng
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: