ICEfaces
  1. ICEfaces
  2. ICE-5990

Support Liferay 6.0

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2, 1.8.2-EE-GA_P01
          • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            Liferay 6.0.3, ICEfaces 1.8.x
          • Affects:
            Compatibility/Configuration

            Description

            Due to a JS naming collision between ICEfaces use of Prototype and Liferay's use of YUI, it is currently not possible to use ICEfaces 1.8 with Liferay 6.

            See the Liferay issue case for more details: http://issues.liferay.com/browse/LPS-11469

              Issue Links

              depends on

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5989 CLONE -Hide Prototype, Scriptaculous component JS variables/functions to avoid collisions with 3rd party JS libs.

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Ken Fyten created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Salesforce Case []
                Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
                Fix Version/s 1.8.3 [ 10211 ]
                Affects [Compatibility/Configuration]
                Assignee Ken Fyten [ ken.fyten ]
                Hide
                Permalink
                Ken Fyten added a comment -

                ICE-5989 needs to be resolved before this will work properly.

                Show
                Ken Fyten added a comment - ICE-5989 needs to be resolved before this will work properly.
                Ken Fyten made changes -
                Link This issue depends on ICE-5989 [ ICE-5989 ]
                Ken Fyten made changes -
                Salesforce Case []
                Description Due to a JS naming collision between ICEfaces use of Prototype and Liferay's use of YUI, it is currently not possible to use ICEfaces 1.8 with Liferay 6.

                		 Due to a JS naming collision between ICEfaces use of Prototype and Liferay's use of YUI, it is currently not possible to use ICEfaces 1.8 with Liferay 6.

                See the Liferay issue case for more details: http://issues.liferay.com/browse/LPS-11469
                Hide
                Permalink
                Ted Goddard added a comment -

                Claimed modification for prototype.js:

                https://prototype.lighthouseapp.com/projects/8886/tickets/453/

                Show
                Ted Goddard added a comment - Claimed modification for prototype.js: https://prototype.lighthouseapp.com/projects/8886/tickets/453/
                Arran Mccullough made changes -
                Salesforce Case [5007000000E3dnN]
                Ken Fyten made changes -
                Assignee Priority P1
                Assignee Ken Fyten [ ken.fyten ] Deryk Sinotte [ deryk.sinotte ]
                Deryk Sinotte made changes -
                Assignee Deryk Sinotte [ deryk.sinotte ] Mircea Toma [ mircea.toma ]
                Hide
                Permalink
                Deryk Sinotte added a comment -

                Linking to http://jira.icefaces.org/browse/ICE-5989 as once the Prototype "hiding" is done we should retest. If it's still a problem then we'll need to pursue another solution.

                Show
                Deryk Sinotte added a comment - Linking to http://jira.icefaces.org/browse/ICE-5989 as once the Prototype "hiding" is done we should retest. If it's still a problem then we'll need to pursue another solution.
                Hide
                Permalink
                Mircea Toma added a comment -

                Hiding the variables declared by Prototype as described in ICE-5989 will not help because the 'toJSON' function is attached to a native object's prototype effectively making this a globally accessible function. The only viable solution is to remove 'toJSON' definition in Prototype library since neither the bridge or the components are using this function.

                Show
                Mircea Toma added a comment - Hiding the variables declared by Prototype as described in ICE-5989 will not help because the 'toJSON' function is attached to a native object's prototype effectively making this a globally accessible function. The only viable solution is to remove 'toJSON' definition in Prototype library since neither the bridge or the components are using this function.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23037 Thu Nov 04 16:56:44 MDT 2010 mircea.toma ICE-5990 Renamed toJSON methods defined by Protoype to toJSON_Prototype to avoid overriding the native toJSON methods already defined in modern browsers.
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/hash.js
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/string.js
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/array.js
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/number.js
                Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/prototype/base.js
                Hide
                Permalink
                Mircea Toma added a comment -

                Renamed toJSON methods defined by Protoype to toJSON_Prototype to avoid overriding the native toJSON methods already defined in modern browsers.

                Show
                Mircea Toma added a comment - Renamed toJSON methods defined by Protoype to toJSON_Prototype to avoid overriding the native toJSON methods already defined in modern browsers.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #23041 Fri Nov 05 09:07:47 MDT 2010 mircea.toma ICE-5990 Renamed toJSON methods defined by Protoype to toJSON_Prototype to avoid overriding the native toJSON methods already defined in modern browsers.
                Files Changed
                Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
                Hide
                Permalink
                Mircea Toma added a comment -

                Modified glimmer/compat Prototype code as well.

                Show
                Mircea Toma added a comment - Modified glimmer/compat Prototype code as well.
                Mircea Toma made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s 2.0.0 [ 10230 ]
                Assignee Priority P1
                Ken Fyten made changes -
                Summary ICEfaces 1.8.x does not work properly with Liferay 6.0.3 Support Liferay 6.0
                Issue Type Improvement [ 4 ] New Feature [ 2 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Mircea Toma
                    Reporter:
                    Ken Fyten
                  • Votes:
                    1 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: