ICEfaces
  1. ICEfaces
  2. ICE-5956

Chrome reports "extra body tag found" when using Compat. Component Showcase

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 2.0 compat Component Showcase
          • Affects:
            Sample App./Tutorial

            Description

            The chrome browser reports "Extra <body> encountered. Migrating attributes back to the original <body> element and ignoring the tag." when component-showcase is loaded.

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Hide
              Permalink
              Ted Goddard added a comment -

              Assigning to Deryk to assign.

              Show
              Ted Goddard added a comment - Assigning to Deryk to assign.
              Ted Goddard made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I think this is likely an application issue. Chrome does complain about a few things that it "fixes" for us but it doesn't look good. It may not occur on the initial load of the page, but subsequent interaction/reloads do seem to show it. Attaching a screenshot for clarity.

              Show
              Deryk Sinotte added a comment - I think this is likely an application issue. Chrome does complain about a few things that it "fixes" for us but it doesn't look good. It may not occur on the initial load of the page, but subsequent interaction/reloads do seem to show it. Attaching a screenshot for clarity.
              Deryk Sinotte made changes -
              Environment ICEfaces 2.0 compat ICEfaces 2.0 compat Component Showcase
              Salesforce Case []
              Component/s Sample Apps [ 10010 ]
              Component/s Framework [ 10013 ]
              Assignee Deryk Sinotte [ deryk.sinotte ] Ken Fyten [ ken.fyten ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Issues that Chrome is reporting but, perhaps, automatically "fixing" for us.

              Show
              Deryk Sinotte added a comment - Issues that Chrome is reporting but, perhaps, automatically "fixing" for us.
              Deryk Sinotte made changes -
              Attachment chrome-warnings.png [ 12494 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Can you take a look, maybe we're injecting more than one body tag via the dynamic includes, etc.

              Show
              Ken Fyten added a comment - Can you take a look, maybe we're injecting more than one body tag via the dynamic includes, etc.
              Ken Fyten made changes -
              Summary extra body tag found Chrome reports "extra body tag found" when using Compat. Component Showcase
              Salesforce Case []
              Affects [Sample App./Tutorial]
              Assignee Priority P2
              Assignee Ken Fyten [ ken.fyten ] Patrick Corless [ patrick.corless ]
              Hide
              Permalink
              Patrick Corless added a comment -

              It would appear that the <f:view locale="#

              {localeBean.currentLanguage}

              " contentType="text/html"> contextType is causing chrome grief. Once removed the page render without any errors, I'll to a little more testing and check in the modified code.

              Show
              Patrick Corless added a comment - It would appear that the <f:view locale="# {localeBean.currentLanguage} " contentType="text/html"> contextType is causing chrome grief. Once removed the page render without any errors, I'll to a little more testing and check in the modified code.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22237 Thu Aug 26 06:38:06 MDT 2010 patrick.corless ICE-5956 removed contentType from <f:view/> tag which fixes an issue with chrome indicating that a double body and incomplete header is in the page.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/templates/page-template.xhtml
              Hide
              Permalink
              Patrick Corless added a comment -

              I chatted with Mark about the behaviour and couldn't come up with a good reason for the behaviour, likely just some strange browser bug. If we see something like this I guess we could create little test program to see see what the raw HTML looks like on the initial response.

              Resolving issue, code has been checked in.

              Show
              Patrick Corless added a comment - I chatted with Mark about the behaviour and couldn't come up with a good reason for the behaviour, likely just some strange browser bug. If we see something like this I guess we could create little test program to see see what the raw HTML looks like on the initial response. Resolving issue, code has been checked in.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ted Goddard added a comment -

              This change appears to break rendering completely on chrome and Safari on the Mac.

              Show
              Ted Goddard added a comment - This change appears to break rendering completely on chrome and Safari on the Mac.
              Ted Goddard made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Patrick Corless [ patrick.corless ] Ken Fyten [ ken.fyten ]
              Ted Goddard made changes -
              Attachment Screen shot 2010-09-17 at 1.37.52 PM.png [ 12567 ]
              Hide
              Permalink
              Ted Goddard added a comment -

              Assigned to Ken for either reproduction by QA or assignment.

              Show
              Ted Goddard added a comment - Assigned to Ken for either reproduction by QA or assignment.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22382 Mon Sep 20 15:25:22 MDT 2010 deryk.sinotte ICE-5956: normalized link tag output to avoid spans and closing link tags
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/src/org/icefaces/application/showcase/util/StyleBean.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/samples/component-showcase/web/WEB-INF/includes/templates/page-template.xhtml
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I set the contentType in the f:view back to text/html as WebKit browsers get borked if that's not set.

              The fix to get WebKit browsers to not complain was to rationalize the link tags so that:

              1) Any </link> tags are removed as links should be self terminated (since they don't have children). I changed the static links in the markup as well as the dynamically generated link in the StyleBean.
              2) The h:output text was changed to an ice:outputText with nospan=true to avoid rendering a span.

              Show
              Deryk Sinotte added a comment - I set the contentType in the f:view back to text/html as WebKit browsers get borked if that's not set. The fix to get WebKit browsers to not complain was to rationalize the link tags so that: 1) Any </link> tags are removed as links should be self terminated (since they don't have children). I changed the static links in the markup as well as the dynamically generated link in the StyleBean. 2) The h:output text was changed to an ice:outputText with nospan=true to avoid rendering a span.
              Deryk Sinotte made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Ken Fyten
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: