Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Beta2
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Server: Tomcat6
Browser: FF3.6, IE7 & Opera10.10
Description
Cannot open Popup Calendar by clicking on calendar button.
Test-cases can be found at "C:\repo\qa\trunk\Regression-Icefaces2\Nightly\
Other cases failing due to same problem are:
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
When the 'value' attribute of the input element is updated with an empty string its value is not changed by Safari back to 'on' when the checkbox is checked (see also http://updatepanel.net/2009/06/10/webkit-bug-default-value-of-unchecked-checkbox-element-is-an-empty-string/ ). Thus when JSF serializes the checkbox the parameter corresponding to the checkbox will have the empty string as value which is interpreted by CheckboxRenderer as an un-checked checkbox.
To solve the issue CheckboxRenderer will always render 'value=on' attribute for the checkbox to guarantee that when the element is updated and then serialized the value is not empty. Having the 'value' attribute always set to 'on' doesn't interfere with the serialization, when the input element is not checked ('checked' attribute is false) its serialization is skipped.
Changed SelectInputDateRenderer to render its required hidden input field (client ID + '_cc') by using FormRenderer.addHiddenField API.
Capture and log exception thrown when focus method is invoked on invisible elements.
Couple of things:
I fixed an issue related to SelectInputDateRenderer where changes from the compat component re-sync (ICE-5665) - the original changes at revision 22019 and another adjustment at 22028 had left an id suffix (j_idcl) only changed in one spot but where it was actually used in two. I created a class constant and now it's used properly in both methods.
I also adjusted the test a bit. There is an issue with WebKit browsers where, by default, they ask for xhtml content type rather than text/html. The issue is explained in more detail in http://jira.icefaces.org/browse/ICE-5825. The bottom line is that some components don't render strict html compliant output which causes Safari and Chrome to complain or fail. The SelectInputDateRenderer is one of these. For applications that use the Calendar, like Component Showcase, the workaround is to add the f:view tag with the contentType attribute set to text/html:
<html...
<f:view contentType="text/html">
<head...
...
</f:view>
<html>
ICEfaces 2 revision = 22371
Sparke revision = 22371
Verified IE focus management problem fixed.
Verified IE hidden field problem fixed.
Verified Safari checkbox problem fixed.