ICEfaces
  1. ICEfaces
  2. ICE-5922

ACE Generator use naming conventions

          Details

          • Type: Improvement Improvement
          • Status: Open
          • Priority: Major Major
          • Resolution: Unresolved
          • Affects Version/s: 2.0-Beta2
          • Fix Version/s: None
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            sparkle

            Description

            Looking at a typical sparkle Meta class:

            @Component(
                tagName = "inputFiles",
                componentClass = "org.icefaces.component.inputFiles.InputFiles",
                rendererClass = "org.icefaces.component.inputFiles.InputFilesRenderer",
                generatedClass = "org.icefaces.component.inputFiles.InputFilesBase",
                extendsClass = "javax.faces.component.UIComponentBase",
                componentType = "org.icefaces.faces.InputFiles",
                rendererType = "org.icefaces.faces.InputFilesRenderer",
                componentFamily = "org.icefaces.faces.InputFiles"
            )

            We see that there are a lot of redundantly specified class names, which could be derived from the Meta class' own class name and package name. Or from the tagName.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Affects Version/s 2.0-Beta2 [ 10242 ]
              Affects Version/s 2.0-Alpha3 [ 10032 ]
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 2.0.0 [ 10230 ]
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Ken Fyten made changes -
              Summary sparkle generator use naming conventions ACE Generator use naming conventions
              Salesforce Case []
              Component/s ACE-Components [ 10050 ]
              Component/s Components [ 10012 ]
              Fix Version/s 2.0.0 [ 10230 ]
              Assignee Arturo Zambrano [ artzambrano ]
              Hide
              Permalink
              Mark Collette added a comment -

              The new @JSP annotation uses conventions for the default values of the annotation fields, derived from the Meta class. But @Component doesn't because of how we chose to define componentClass and generatedClass, such that when componentClass is omitted, it defaults to being generatedClass.

              Show
              Mark Collette added a comment - The new @JSP annotation uses conventions for the default values of the annotation fields, derived from the Meta class. But @Component doesn't because of how we chose to define componentClass and generatedClass, such that when componentClass is omitted, it defaults to being generatedClass.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated: