ICEfaces
  1. ICEfaces
  2. ICE-5913

ICEfaces 2 Compat Components not working with std JSF 2 <h:form> tag

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Beta1
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces 2.0 w/ JSF 2.0.3, Compat. Comp. Showcase
    • Affects:
      Compatibility/Configuration

      Description

      Using the Compat Component Showcase sample app, checked all .xhtml files under folders and sub-folders of component-showcase\web\WEB-INF\includes. Only three files have ice:form presenting. None of the ice:form has the "partialSubmit=true" attribute defined. Those three files are:

      includes\templates\page-template.xhtml
      includes\content\navigation.xhtml
      includes\content\languageThemeControl.xhtml

      Replaced the ice:form with h:form in the files, and tested compat showcase. Except for the top level 4 menus (Extended Components, Custom Components, Layout Panels, and Table), none of the demo links in the navigation tree is clickable.

      Tested on Glimmer revision 21939 using Tomcat 6 and FF3.6

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0-Beta2 [ 10242 ]
        Affects [Compatibility/Configuration]
        Assignee Priority P2
        Assignee Deryk Sinotte [ deryk.sinotte ]
        Deryk Sinotte made changes -
        Assignee Deryk Sinotte [ deryk.sinotte ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22018 Mon Jul 26 08:37:12 MDT 2010 mircea.toma ICE-5913 Introduce renderer that exteds h:form renderer to render the hidden input fields required by some ice:* components. Introduce also system event listener that changes the h:form renderer to the overriding render.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/com/icesoft/jsfmeta/templates/jsf11/resources/faces-config-rt.ftl
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/META-INF/faces-config.xml
        Commit graph ADD /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/OverrideDefaultFormRenderers.java
        Hide
        Mircea Toma added a comment -

        Introduced renderer that exteds h:form renderer to render the hidden input fields required by some ice:* components. Introduced also system event listener that changes the h:form renderer to the overriding render.

        Show
        Mircea Toma added a comment - Introduced renderer that exteds h:form renderer to render the hidden input fields required by some ice:* components. Introduced also system event listener that changes the h:form renderer to the overriding render.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mircea Toma made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22059 Fri Jul 30 09:22:27 MDT 2010 mircea.toma ICE-5913 Introduce FormEndRendering utility to allow rendering of markup right before 'form' end tag is rendered. Use utility to render the hidden input fields required by some ice:* components.
        Files Changed
        Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/FormEndRendering.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
        Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/RendererWrapper.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/component-metadata/src/main/resources/com/icesoft/jsfmeta/templates/jsf11/resources/faces-config-rt.ftl
        Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/FormEndRenderer.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/resources/META-INF/faces-config.xml
        Commit graph DEL /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/OverrideDefaultFormRenderers.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/DOMRenderKit.java
        Hide
        Mircea Toma added a comment -

        Introduce FormEndRendering utility to allow rendering of markup right before 'form' end tag is rendered. Use utility to render the hidden input fields required by some ice:* components.

        Show
        Mircea Toma added a comment - Introduce FormEndRendering utility to allow rendering of markup right before 'form' end tag is rendered. Use utility to render the hidden input fields required by some ice:* components.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22065 Fri Jul 30 15:43:54 MDT 2010 ted.goddard FormBoost for cases other than deltaSubmit (ICE-5913)
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/DOMRenderKit.java
        Hide
        Ted Goddard added a comment -

        Modified DOMRenderKit so that FormBoost is applied to all requests for a Form Renderer.

        It may be necessary to add an ICEfaces View check around deltaSubmit rendering code.

        Show
        Ted Goddard added a comment - Modified DOMRenderKit so that FormBoost is applied to all requests for a Form Renderer. It may be necessary to add an ICEfaces View check around deltaSubmit rendering code.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22070 Mon Aug 02 06:35:57 MDT 2010 mircea.toma ICE-5913 Turn on deltaSumit functionality in the client only when the view is ICEfaces enabled.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/DOMRenderKit.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22071 Mon Aug 02 06:37:06 MDT 2010 mircea.toma ICE-5913 Remove check foe deltasubmit when decorating the forms.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/DOMRenderKit.java
        Hide
        Mircea Toma added a comment -

        Turn on deltaSumit functionality in the client only when the view is ICEfaces enabled.

        Show
        Mircea Toma added a comment - Turn on deltaSumit functionality in the client only when the view is ICEfaces enabled.
        Hide
        Mandeep Hayher added a comment -

        Icefaces2 revision# 22161
        Server: Tomcat6
        Browser:FF3.6, IE8 & Opera10.60

        Problems common on all browser:
        1)Drag & Drop not working
        2)Popup Panel: Draggable popup can be dragged only once
        AutoCenter is not working

        Problem on FF3.6 only:
        1)RichText: application tries to reload the page when user tries to save text in RichText.

        Problem on IE8 only:
        1)''Server Internal Error' is seen when trying to use Buttons and Links
        Also following is displayed on the webpage:
        viewId:/showcase.jsf - View /showcase.jsf could not be restored.
        class javax.faces.application.ViewExpiredException

        Show
        Mandeep Hayher added a comment - Icefaces2 revision# 22161 Server: Tomcat6 Browser:FF3.6, IE8 & Opera10.60 Problems common on all browser: 1)Drag & Drop not working 2)Popup Panel: Draggable popup can be dragged only once AutoCenter is not working Problem on FF3.6 only: 1)RichText: application tries to reload the page when user tries to save text in RichText. Problem on IE8 only: 1)''Server Internal Error' is seen when trying to use Buttons and Links Also following is displayed on the webpage: viewId:/showcase.jsf - View /showcase.jsf could not be restored. class javax.faces.application.ViewExpiredException
        Mandeep Hayher made changes -
        Assignee Mircea Toma [ mircea.toma ] Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22173 Sun Aug 15 06:55:55 MDT 2010 mircea.toma ICE-5913 Render icefacesCssUpdates input hidden field using a FormEndRenderer since DnD and popup panel rely on it.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
        Hide
        Mircea Toma added a comment -

        Render icefacesCssUpdates input hidden field using a FormEndRenderer since DnD and popup panel rely on it.

        Show
        Mircea Toma added a comment - Render icefacesCssUpdates input hidden field using a FormEndRenderer since DnD and popup panel rely on it.
        Hide
        Mircea Toma added a comment - - edited

        Check for the existence of Ice.FCKEditorUtility variable in the evaluated sent by InputRichText renderer. When InputRichText is used for the first time Ice.FCKEditorUtility is not yet loaded causing a JS error that stops onAfterUpdate listeners from being invoked. In turn ViewState hidden field is not written thus the following submit will trigger a full page update/reload.

        Show
        Mircea Toma added a comment - - edited Check for the existence of Ice.FCKEditorUtility variable in the evaluated sent by InputRichText renderer. When InputRichText is used for the first time Ice.FCKEditorUtility is not yet loaded causing a JS error that stops onAfterUpdate listeners from being invoked. In turn ViewState hidden field is not written thus the following submit will trigger a full page update/reload.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22177 Mon Aug 16 09:40:03 MDT 2010 mircea.toma ICE-5913 Set 'defaultValue' for the 'javax.faces.ViewState' input element so that a form reset will reassign the same value (the view state key) to the input element.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/javascript/application.js
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/status.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #22178 Mon Aug 16 10:11:48 MDT 2010 mircea.toma ICE-5913 Add todo.
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
        Hide
        Mircea Toma added a comment -

        The IE8 issue can be replicated only when using the 'Reset' button in 'Button and Links' panel. The cause of the exception on the server seems to be the missing value of 'javax.faces.ViewState' parameter. The 'javax.faces.ViewState' field is added dynamically to the updated form without defining a defaultValue attribute for it. When the form is reset the value of 'javax.faces.ViewState' input element is set to its default value, the empty string, which will trigger the exception when the form is eventually submitted.

        The applied fix sets also a 'defaultValue' for the 'javax.faces.ViewState' input element so that a form reset will reassign the same value (the view state key) to the input element.

        Show
        Mircea Toma added a comment - The IE8 issue can be replicated only when using the 'Reset' button in 'Button and Links' panel. The cause of the exception on the server seems to be the missing value of 'javax.faces.ViewState' parameter. The 'javax.faces.ViewState' field is added dynamically to the updated form without defining a defaultValue attribute for it. When the form is reset the value of 'javax.faces.ViewState' input element is set to its default value, the empty string, which will trigger the exception when the form is eventually submitted. The applied fix sets also a 'defaultValue' for the 'javax.faces.ViewState' input element so that a form reset will reassign the same value (the view state key) to the input element.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: