ICEfaces
  1. ICEfaces
  2. ICE-5912

Remove commons-fileupload.jar from glimmer/lib

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Framework, ICE-Components
          • Labels:
            None
          • Environment:
            Glimmer / sparkle

            Description

            Remove commons-fileupload.jar from glimmer/lib, since glimmer has no dependency on it.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-10355 update commons-fileupload library to v1.3.1 for security fix for ice:inputFile

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21963 Mon Jul 19 17:05:33 MDT 2010 mark.collette ICE-5912 : Remove commons-fileupload.jar from glimmer/lib
                Files Changed
                Commit graph DEL /icefaces2/trunk/icefaces/lib/commons-fileupload.jar
                Mark Collette created issue -
                Hide
                Permalink
                Mark Collette added a comment -

                Removed the jar
                Subversion 21963

                Show
                Mark Collette added a comment - Removed the jar Subversion 21963
                Mark Collette made changes -
                Field Original Value New Value
                Assignee Mark Collette [ mark.collette ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21965 Mon Jul 19 20:16:31 MDT 2010 mark.collette ICE-5912 : Remove commons-fileupload.jar from glimmer/lib
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/sparkle/component/build.xml
                Commit graph ADD /icefaces/scratchpads/sparkle/component/lib
                Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/build.xml
                Commit graph ADD /icefaces/scratchpads/sparkle/component/lib/commons-fileupload.jar
                Deryk Sinotte made changes -
                Salesforce Case []
                Fix Version/s 2.0-Beta2 [ 10242 ]
                Assignee Priority P1
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #22140 Mon Aug 09 20:23:26 MDT 2010 mark.collette ICE-5912 : Remove commons-fileupload.jar from glimmer/lib
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/sparkle/component/build.xml
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/MultipartStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util/Streams.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItemHeadersSupport.java
                Commit graph DEL /icefaces/scratchpads/sparkle/component/lib
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/portlet/package.html
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/DiskFileUpload.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/disk/DiskFileItemFactory.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileUpload.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/servlet/ServletFileUpload.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItem.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItemIterator.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/DefaultFileItemFactory.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/output/ThresholdingOutputStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/ParameterParser.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/output
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/DefaultFileItem.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util/package.html
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/output/DeferredFileOutputStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/servlet/package.html
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util/LimitedInputStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/FileDeleteStrategy.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/package.html
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/servlet
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileUploadBase.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/portlet/PortletRequestContext.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/RequestContext.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItemFactory.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileUploadException.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/FileUtils.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/servlet/FileCleanerCleanup.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/IOUtils.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/portlet
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/disk/DiskFileItem.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/ProgressListener.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/disk/package.html
                Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/inputFiles/InputFilesPhaseListener.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/LineIterator.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/portlet/PortletFileUpload.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/servlet/ServletRequestContext.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItemStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/disk
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util/Closeable.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/output/ByteArrayOutputStream.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/io/FileCleaningTracker.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/FileItemHeaders.java
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util
                Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/apache/commons/fileupload/util/FileItemHeadersImpl.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #22142 Mon Aug 09 23:19:22 MDT 2010 mark.collette ICE-5912 : Remove commons-fileupload.jar from glimmer/lib
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/build.xml
                Hide
                Permalink
                Mark Collette added a comment -

                Imported a subset of apache commons fileupload into sparkle. Then imported a portion of apache commons io, which fileupload depended on. Altered the InputFilesPhaseListener to use the imported code, and removed the old jar and any ant usage of the jar.

                It took a certain amount of effort to limit the io dependencies, as each class pulled in more and more of it. Finally, I found a way to include all of upload, even the parts we don't currently use, while truncating the io that we pulled in.

                Subversion 22140
                Subversion 22142

                Show
                Mark Collette added a comment - Imported a subset of apache commons fileupload into sparkle. Then imported a portion of apache commons io, which fileupload depended on. Altered the InputFilesPhaseListener to use the imported code, and removed the old jar and any ant usage of the jar. It took a certain amount of effort to limit the io dependencies, as each class pulled in more and more of it. Finally, I found a way to include all of upload, even the parts we don't currently use, while truncating the io that we pulled in. Subversion 22140 Subversion 22142
                Mark Collette made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Fix Version/s 2.0.0 [ 10230 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Judy Guglielmin made changes -
                Link This issue blocks ICE-10355 [ ICE-10355 ]

                  People

                  • Assignee:
                    Mark Collette
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: