ICEfaces
  1. ICEfaces
  2. ICE-5875

Sparkle pushButton - Adopt latest coding best-practices

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Sparkle components

            Description

            1. (ICE-5831) Adopt JSONBuilder.create() util method for generating parameter strings.

            2. (ICE-5830) Adopt ScriptWriter.insertScript() util method for inserting JavaScript.

            3. (ICE-5832) Adopt the 'ice.submit.type' bridge-maintained parameter for detecting the submit-type while decoding.

            4. (ICE-5805) Ensure that input components (any value-holder comps) are using a hidden form field for the value, and not parameters.

            5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup.

            The Calendar component can be used as a reference, once ICE-5872 is complete).

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Assignee Greg Dick [ greg.dick ] Judy Guglielmin [ judy.guglielmin ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21868 Thu Jul 08 12:11:15 MDT 2010 judy.guglielmin ICE-5875 updates for ICE-5830 and 5831 as 5805 already done and 5832 is not applicable for this component
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
              Hide
              Permalink
              Judy Guglielmin added a comment -

              only required ICE-5831 (JSONBuilder) and 5830 (ScriptWriter) as 5805 already done and 5832 no applicable for this component

              Show
              Judy Guglielmin added a comment - only required ICE-5831 (JSONBuilder) and 5830 (ScriptWriter) as 5805 already done and 5832 no applicable for this component
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21872 Thu Jul 08 14:28:44 MDT 2010 judy.guglielmin ICE-5875. ScriptWriter already takes care of span tag surrounding script tag
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
              Ken Fyten made changes -
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Fix Version/s 2.0-Beta1 [ 10231 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: