ICEfaces
  1. ICEfaces
  2. ICE-5872

Sparkle Calendar - Adopt latest coding best-practices

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Beta1
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Sparkle components

            Description

            1. (ICE-5831) Adopt JSONBuilder.create() util method for generating parameter strings.

            2. (ICE-5830) Adopt ScriptWriter.insertScript() util method for inserting JavaScript.

            3. (ICE-5832) Adopt the 'ice.submit.type' bridge-maintained parameter for detecting the submit-type while decoding.

            4. (ICE-5805) Ensure that input components (any value-holder comps) are using a hidden form field for the value, and not parameters.

            5. Ensure that the component renderer is creating the recommended component hierarchy of a surrounding DIV (with ID), which itself contains the script elements generated by the ScriptWriter.insertScript() function (step 2 above), followed by another DIV which contains the rest of the component markup.
            1. screenshot-01.png
              196 kB
            2. screenshot-02.png
              201 kB
            3. screenshot-03.png
              197 kB
            4. screenshot-04.png
              159 kB
            5. screenshot-05.png
              168 kB

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Fix Version/s 2.0-Beta [ 10231 ]
              Assignee Yip Ng [ yip.ng ]
              Ken Fyten made changes -
              Salesforce Case []
              Assignee Priority P1
              yip.ng made changes -
              Attachment screenshot-01.png [ 12431 ]
              yip.ng made changes -
              Attachment screenshot-02.png [ 12432 ]
              yip.ng made changes -
              Attachment screenshot-03.png [ 12433 ]
              yip.ng made changes -
              Attachment screenshot-04.png [ 12434 ]
              yip.ng made changes -
              Attachment screenshot-05.png [ 12435 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21884 Fri Jul 09 13:02:25 MDT 2010 yip.ng ICE-5872: Sparkle Calendar - Adopt latest coding best-practices.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/selectinputdate/SelectInputDate.java
              Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/calendar.xhtml
              Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/selectinputdate/SelectInputDateRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.selectinputdate/calendar.js
              Hide
              Permalink
              yip.ng added a comment -

              1. Done. See screenshot 1.

              2. Done. See screenshot 2.

              3. Done. See screenshot 3.

              4. Done. See screenshot 4.

              5. Done. See screenshot 5.

              Show
              yip.ng added a comment - 1. Done. See screenshot 1. 2. Done. See screenshot 2. 3. Done. See screenshot 3. 4. Done. See screenshot 4. 5. Done. See screenshot 5.
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Fix Version/s 2.0-Beta1 [ 10231 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  yip.ng
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: