ICEfaces
  1. ICEfaces
  2. ICE-5844

Hide Prototype, Scriptaculous and 'compat' component JS variables/functions

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta2, 2.0.0
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            ICEfaces 2.0 Compat APIs.
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description

            To avoid any variable name conflict with third party libraries the code in Prototype, Scriptaculous and 'compat' component should be evaluated within a function local context.

              Activity

              Ascending order - Click to sort in descending order
              Mircea Toma created issue -
              Mircea Toma made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Mircea Toma made changes -
              Salesforce Case []
              Fix Version/s 2.0-Beta [ 10231 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              This needs to be configurable to preserve backwards compatibility with apps or custom components that are relying on the public Prototype JS apis.

              Show
              Ken Fyten added a comment - This needs to be configurable to preserve backwards compatibility with apps or custom components that are relying on the public Prototype JS apis.
              Ken Fyten made changes -
              Environment browser ICEfaces 2.0 Compat APIs.
              Salesforce Case []
              Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
              Tyler Johnson made changes -
              Salesforce Case [5007000000C4SA0]
              Hide
              Permalink
              Ken Fyten added a comment -

              Upon reflection, we probably don't need the configuration aspect for ICEfaces 2.0 compat mode, users can link to the Prototype.js themselves if they require it in 2.0.

              Show
              Ken Fyten added a comment - Upon reflection, we probably don't need the configuration aspect for ICEfaces 2.0 compat mode, users can link to the Prototype.js themselves if they require it in 2.0.
              Ken Fyten made changes -
              Assignee Priority P2
              Ken Fyten made changes -
              Fix Version/s 2.0-Beta2 [ 10242 ]
              Fix Version/s 2.0-Beta1 [ 10231 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21989 Tue Jul 20 16:22:03 MDT 2010 mircea.toma ICE-5844 Hide Prototype and Scriptaculous variable/function definitions by wrapping in a closure that is executed immediately. Make functions used by component renderers public, but namespace them to avoid naming collisions. Change renderers to use these new function names.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/InputRichTextRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/SwitchOff.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Scale.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/SlideDown.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/BlindDown.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Pulsate.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Fade.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Puff.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Grow.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Move.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Squish.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/build.javascript.xml
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/LocalEffectEncoder.java
              Commit graph ADD /icefaces2/trunk/icefaces/compat/core/src/main/javascript/compat.footer.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/inputrichtext/fckeditor_ext.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Fold.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/DragDrop.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/tree/TreeRenderer.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Shrink.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Opacity.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/SlideUp.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/BlindUp.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/prototype/prototype.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Highlight.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Shake.java
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/Appear.java
              Commit graph ADD /icefaces2/trunk/icefaces/compat/core/src/main/javascript/compat.header.js
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/effects/DropOut.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21990 Tue Jul 20 16:35:48 MDT 2010 mircea.toma ICE-5844 Hide Prototype and Scriptaculous variable/function definitions by wrapping in a closure that is executed immediately. Make functions used by component renderers public, but namespace them to avoid naming collisions. Change renderers to use these new function names.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Prototype and Scriptaculous variable/function definitions are hidden now by wrapping them in a closure that is executed right away the icefaces-compat.js resource loads. Made public the functions used by component renderers, but namespaced them to avoid naming collisions. Changed renderers to use the new namespaced function names.

              Show
              Mircea Toma added a comment - - edited Prototype and Scriptaculous variable/function definitions are hidden now by wrapping them in a closure that is executed right away the icefaces-compat.js resource loads. Made public the functions used by component renderers, but namespaced them to avoid naming collisions. Changed renderers to use the new namespaced function names.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: