ICEfaces
  1. ICEfaces
  2. ICE-5815

Compat: Override UIData.visitTree() method in ice.UISeries.visitTree() to work-around JSF 2 check for UIColumn

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 2 compat components based on UISeries
          • Affects:
            Compatibility/Configuration

            Description

            After analysis of the root cause of the failure in ICE-5790 it has become apparent that in JSF 2 they have changed the implementation of the UIData.visitTree() method to discriminate for UIColumn child components. This new test breaks many of our ICEfaces 1.x components based on ice.UISeries.

            The suggested workaround is to override the visitTree() method in our ice.UISeries class to implement a version of the JSF2 UIData.visitTree() logic that also works for none-UIColumn child components.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-5790 Compat Regression: ICE-3057 Resizable columns should save the state optionally

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. ICE-4351 Compat.: Nested UIData components not working

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Ken Fyten created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Link This issue blocks ICE-5790 [ ICE-5790 ]
                Ken Fyten made changes -
                Salesforce Case []
                Fix Version/s 2.0-Beta [ 10231 ]
                Affects [Compatibility/Configuration]
                Assignee Priority P1
                Assignee Yip Ng [ yip.ng ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21718 Thu Jun 10 14:57:02 MDT 2010 yip.ng ICE-5815: Compat: Override UIData.visitTree() method in ice.UISeries.visitTree() to work-around JSF 2 check for UIColumn.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelseries/UISeries.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21720 Thu Jun 10 15:56:03 MDT 2010 yip.ng ICE-5815: Compat: Override UIData.visitTree() method in ice.UISeries.visitTree() to work-around JSF 2 check for UIColumn. Fixed compile error.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelseries/UISeries.java
                yip.ng made changes -
                Attachment screenshot-1.png [ 12407 ]
                Hide
                Permalink
                yip.ng added a comment - - edited

                Done. See screenshot-1 for the gist of the changes. visitTree() is public, but the changes are not in visitTree(), they are in a private method called by visitTree(). visitTree() also calls other private methods as well. All these private methods have to be copied over to UISeries as well as visitTree() itself.

                Show
                yip.ng added a comment - - edited Done. See screenshot-1 for the gist of the changes. visitTree() is public, but the changes are not in visitTree(), they are in a private method called by visitTree(). visitTree() also calls other private methods as well. All these private methods have to be copied over to UISeries as well as visitTree() itself.
                yip.ng made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Mark Collette made changes -
                Link This issue blocks ICE-4351 [ ICE-4351 ]
                Ken Fyten made changes -
                Fix Version/s 2.0.0 [ 10230 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Hide
                Permalink
                yip.ng added a comment -

                Updated to use UIData code from Mojarra version 2.1.3. See ICE-7185 for details.

                Show
                yip.ng added a comment - Updated to use UIData code from Mojarra version 2.1.3. See ICE-7185 for details.

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    Ken Fyten
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: