ICEfaces
  1. ICEfaces
  2. ICE-5813

overzealous ICEfaces disabled logging

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2.0
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description


            The following logging message appears even when the view is specifically configured not to be an ICEfaces view:

            INFO: ICEfaces disabled for view /nonicefaces.xhtml (h:head and h:body tags must be used)

            BridgeSetup should not log anything in this case (when the configuration is explicit.)

                public void processEvent(SystemEvent event) throws AbortProcessingException {
                    final FacesContext context = FacesContext.getCurrentInstance();

                    if (!EnvUtils.isICEfacesView(context)) {
                        if (log.isLoggable(Level.INFO)) {
                            log.log(Level.INFO, "ICEfaces disabled for view " + context.getViewRoot().getViewId() +
                                    " (h:head and h:body tags must be used)");
                        }
                        return;
                    }

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Deryk Sinotte made changes -
              Salesforce Case []
              Fix Version/s 2.0-Beta [ 10231 ]
              Assignee Priority P2
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21892 Tue Jul 13 09:34:40 MDT 2010 deryk.sinotte ICE-5813: improve logging by separating logic for detecting whether ICEfaces is configured for a view and whether it can actually process the view (check for h:head and h:body components)
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/util/EnvUtils.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/BridgeSetup.java
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I've separated the logic that checks:

              • whether ICEfaces is actually configured for a view
              • whether the h:head and h:body components are available in a view

              If ICEfaces is not configured for a view, either globally using the org.icefaces.render.auto (which defaults to true if it's not set explicitly) or using the <ice:config render="true" /> component, then no check is made for the h:head and h:body components and nothing is logged.

              If ICEfaces is configured for a view, then a check for h:head and h:body components is done and, if not found, a WARNING level log statement is written.

              Show
              Deryk Sinotte added a comment - I've separated the logic that checks: whether ICEfaces is actually configured for a view whether the h:head and h:body components are available in a view If ICEfaces is not configured for a view, either globally using the org.icefaces.render.auto (which defaults to true if it's not set explicitly) or using the <ice:config render="true" /> component, then no check is made for the h:head and h:body components and nothing is logged. If ICEfaces is configured for a view, then a check for h:head and h:body components is done and, if not found, a WARNING level log statement is written.
              Deryk Sinotte made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: