ICEfaces
  1. ICEfaces
  2. ICE-5790

Compat Regression: ICE-3057 Resizable columns should save the state optionally

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha3
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Tomcat6 & FF3.6

            Description

            Resizable columns is not saving the state when resize= true & clientOnly= false.

            Test case available at 'C:\repo\qa\trunk\Regression-Icefaces2\Nightly\ICE-3057'

              Issue Links

              depends on

              Task - A task that needs to be done. ICE-5815 Compat: Override UIData.visitTree() method in ice.UISeries.visitTree() to work-around JSF 2 check for UIColumn

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Mandeep Hayher created issue -
                Mandeep Hayher made changes -
                Field Original Value New Value
                Assignee Ken Fyten [ ken.fyten ]
                Ken Fyten made changes -
                Salesforce Case []
                Fix Version/s 2.0-Beta [ 10231 ]
                Assignee Priority P2
                Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
                Hide
                Permalink
                Mircea Toma added a comment -

                With attributes set to resize= true & clientOnly= false, the columns keep their resized dimension after reload.

                Show
                Mircea Toma added a comment - With attributes set to resize= true & clientOnly= false, the columns keep their resized dimension after reload.
                Mircea Toma made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Cannot Reproduce [ 5 ]
                Hide
                Permalink
                Mandeep Hayher added a comment -

                1)On loading the application, attribute values should be displayed as 'resize: true clientOnly: false' on the webpage
                2)resize columns
                3)change to tab1
                4)now come back to tab0
                all the resizing of the columns is lost.

                Test case available at 'C:\repo\qa\trunk\Regression-Icefaces2\Nightly\ICE-3057'

                Show
                Mandeep Hayher added a comment - 1)On loading the application, attribute values should be displayed as 'resize: true clientOnly: false' on the webpage 2)resize columns 3)change to tab1 4)now come back to tab0 all the resizing of the columns is lost. Test case available at 'C:\repo\qa\trunk\Regression-Icefaces2\Nightly\ ICE-3057 '
                Mandeep Hayher made changes -
                Resolution Cannot Reproduce [ 5 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21691 Tue Jun 08 07:19:58 MDT 2010 mircea.toma ICE-5790 Inherit from UIColumn to make save/restore processes work for the children of PanelTabSet.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTab.java
                Hide
                Permalink
                Mircea Toma added a comment -

                The reason why the state of the columns is not saved is due to how UIData components are visiting their children during save/restore process. PanelTabSet is inheriting the behavior visitTree() method from the UIData component. UIData.visitTree() method will recursively traverse its children only if they are instance of javax.faces.component.UIColumn (see UIDate.visitColumnsAndRows method). Since PanelTab is currently an instance of javax.faces.component.html.HtmlPanelGroup, it blocks the traversing and eventually saving/restoring the state of its direct children and grand-children.

                The solution was to make PanelTab inherit from UIColumn class.

                Show
                Mircea Toma added a comment - The reason why the state of the columns is not saved is due to how UIData components are visiting their children during save/restore process. PanelTabSet is inheriting the behavior visitTree() method from the UIData component. UIData.visitTree() method will recursively traverse its children only if they are instance of javax.faces.component.UIColumn (see UIDate.visitColumnsAndRows method). Since PanelTab is currently an instance of javax.faces.component.html.HtmlPanelGroup, it blocks the traversing and eventually saving/restoring the state of its direct children and grand-children. The solution was to make PanelTab inherit from UIColumn class.
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Somebody from Component team should validate the fix.

                Show
                Mircea Toma added a comment - Somebody from Component team should validate the fix.
                Ken Fyten made changes -
                Assignee Mircea Toma [ mircea.toma ] Mark Collette [ mark.collette ]
                Ken Fyten made changes -
                Salesforce Case []
                Assignee Priority P2 P1
                Ken Fyten made changes -
                Link This issue depends on ICE-5815 [ ICE-5815 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                The change Mircea committed for this should be backed-out once ICE-5815 is fixed.

                Show
                Ken Fyten added a comment - The change Mircea committed for this should be backed-out once ICE-5815 is fixed.
                Ken Fyten made changes -
                Salesforce Case []
                Assignee Mark Collette [ mark.collette ] Yip Ng [ yip.ng ]
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21719 Thu Jun 10 15:02:30 MDT 2010 yip.ng ICE-5790: Compat Regression: ICE-3057 Resizable columns should save the state optionally -- backout previous changes.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTab.java
                Hide
                Permalink
                yip.ng added a comment -

                ICE-5815 done. Previous changes for this case backed out.

                Show
                yip.ng added a comment - ICE-5815 done. Previous changes for this case backed out.
                yip.ng made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Mandeep Hayher added a comment -

                Tested successfully on Glimmer revision# 21736, Tomcat6 & FF3.6

                Show
                Mandeep Hayher added a comment - Tested successfully on Glimmer revision# 21736, Tomcat6 & FF3.6
                Ken Fyten made changes -
                Fix Version/s 2.0.0 [ 10230 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    Mandeep Hayher
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: