Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Alpha3
-
Component/s: ICE-Components
-
Labels:None
-
Environment:sparkle
Description
The action attribute is represented in the component by MethodExpression getActionExpression() and void setActionExpression(MethodExpression) methods. As well, there are deprecated legacy MethodBinding getAction() and void setAction(MethodBinding) methods, which use wrapper code to call into the ActionExpression methods.
The actionListener attribute is even more complicated, with the preferred API involving void addActionListener(ActionListener), void removeActionListener(ActionListener), ActionListener[] getActionListeners(). This means that there's no classical getter/setter, and any Tag class or Facelets Handler class would have to use javax.faces.event.MethodExpressionActionListener to wrap the MethodExpression with an ActionListener implementation.
The immediate attribute behaves like any other property, but its TLD doc and Javadoc has a different explanation than the UIInput variant of immediate.
With sparkle, we can see two main scenarios for Meta classes using ActionSource2. The first is where the generated Base class in some way extends a concrete implementation of ActionSource2, like UICommand. The second scenario is where the generated Base class itself should implement ActionSource2, effectively duplicating UICommand.
In the first scenario, we only want to create entries for action/actionListener/immediate in the xml files, like the TLD. We don't want to generate any code in the Base class, and need only properly invoke setActionExpression(-), addActionListener, setImmediate(-) from the JSP Tag class. It's not necessary for creating Facelets Handler code, since Facelets already does this. We'll have to find a way to represent this in the Meta class. The typical inherit/useTemplate fields don't exactly cover the scope of alteration necessary. And with immediate, we'd still have to add some way of differentiating between the two immediate attributes.
In the second scenario, we would have to generate all the code that UICommand already has, into the Base class, then do everything from the above scenario as well. It's likely that the Meta class would have to specify something to differentiate the two scenarios, such as have inherit=false.
Issue Links
- blocks
-
ICE-5753
New PushButton ACE component.
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Got it. Now we have to come up with a way to define meta data for both of these scenario:
My suggestion:
Scenario 1- Meta class that doesn't extends ActionSource type of class and would like to generated an ActionSource type of component.
@Component(.......
isActionSource=true
)
public class Button
As we can see in above example that we are setting a property at class level annotation. Which is saying that it is going to be a actionsource type. So the generator can implement appropriate interface and generate other artifacts as well.
Scenario 2- Component that extends UICommand or any component that is a type of ActionSource2.
If the extended component is a type of ActionSource2 then generator automatically add action, actionListener and immediate into tld and tag classes. No need to define metadata in Meta class?
Please let me know if that sounds good. So I can proceed?
Tag class enabled so the TLD docs can be generated, and changes made to the generator to use ActionSource2 methods to register action and actionListener.
Command: Commit
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\pushbutton\PushButtonMeta.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\TagClassGenerator.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\component\src\org\icefaces\component\pushbutton\PushButtonMeta.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\TagClassGenerator.java
Completed: At revision: 21552
Preliminary code added to plug behavior.
Command: Commit
Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\component\annotation\ActionSource.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\artifacts\ComponentArtifact.java
Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\behavior
Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\behavior\ActionSourceBehavior.java
Adding: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\behavior\Behavior.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\context\ComponentContext.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\context\GeneratorContext.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\context\ComponentContext.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\behavior\ActionSourceBehavior.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\behavior\Behavior.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\context\GeneratorContext.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\generator\artifacts\ComponentArtifact.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\scratchpads\sparkle\generator\src\org\icefaces\component\annotation\ActionSource.java
Completed: At revision: 21721
Adnan re-enabled it, with his fix. I found the TLD file here: sparkle\component\build\exploded\META-INF\components.tld
committed workaround to disable the jsp tag writing for UICommnad (doesn't accomodate ActionSource2 ability of UICommand).
Note also some modifications for debug statements (when property is null). Also, had to modify property annotations for the properties "action" and "actionListener"