ICEfaces
  1. ICEfaces
  2. ICE-5747

Compat Showcase: Tree demo in FF3.6

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Alpha3
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      FF3.6
    • Assignee Priority:
      P1

      Description

      Compat Showcase Tree demo:

      In FF3.6, clicking the <Move Up> or <Move Down> button once will actually make the name moving over two rows instead of one.

      Using Chrome, it works correctly (only moves one row at a time).

        Activity

        Joanne Bai created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0-Alpha3 [ 10032 ]
        Affects Version/s 2.0-Alpha3 [ 10032 ]
        Affects Version/s 2.0-Alpha2 [ 10214 ]
        Description Compat Showcase Tree demo:

        In FF3.6, clicking the <Move Up> or <Move Down> button once will actually make the name moving over two rows instead of one
        Compat Showcase Tree demo:

        In FF3.6, clicking the <Move Up> or <Move Down> button once will actually make the name moving over two rows instead of one.

        Using Chrome, it works correctly (only moves one row at a time).
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1
        Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
        Hide
        yip.ng added a comment -

        Nothing wrong with the tree. It's the button. Every click triggers the button decode() twice. Seems every click generates 2 posts. There is also a bridge JS error. See video at: http://screencast.com/t/MWFjMWM0N

        Show
        yip.ng added a comment - Nothing wrong with the tree. It's the button. Every click triggers the button decode() twice. Seems every click generates 2 posts. There is also a bridge JS error. See video at: http://screencast.com/t/MWFjMWM0N
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Yip Ng [ yip.ng ] Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Mark Collette [ mark.collette ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #21557 Mon May 31 08:56:23 MDT 2010 mircea.toma ICE-5747 Infer form element from the submitting element in case 'form' parameter is null.
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/javascript/submit.js
        Hide
        Mircea Toma added a comment -

        For some reason unknown to me, FF doesn't set 'form' variable when button's onclick event listener is invoked. This causes the resetHiddenFieldsFor() function to fail (throw error) and eventually the listener code fails to return. The listener normally returns 'false' to block the event from propagating to the form element which would cause another submit. Because the listener code fails we see the double submit.

        The fix introduced infers the form from the submitting element in case 'form' parameter is null.

        Show
        Mircea Toma added a comment - For some reason unknown to me, FF doesn't set 'form' variable when button's onclick event listener is invoked. This causes the resetHiddenFieldsFor() function to fail (throw error) and eventually the listener code fails to return. The listener normally returns 'false' to block the event from propagating to the form element which would cause another submit. Because the listener code fails we see the double submit. The fix introduced infers the form from the submitting element in case 'form' parameter is null.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Joanne Bai added a comment -

        verified successfully using icefaces-2.0.0-alpha3

        Show
        Joanne Bai added a comment - verified successfully using icefaces-2.0.0-alpha3
        Joanne Bai made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Joanne Bai
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: