ICEfaces
  1. ICEfaces
  2. ICE-5735

Compat. Calendar component not displayed properly inside <ice:panelGrid> <center> <ice:panelGroup>

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Beta1, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Tomcat6
      FF3.6

      Description

      When calendar component is placed under <ice:panelGrid><center> <ice:panelGroup>
      The application does not loaded properly (panel grid appears as if it has 2 rows , when it should show everything in 1 row)
      1. screenshot-1.jpg
        88 kB
      2. screenshot-2.png
        142 kB
      3. screenshot-3.png
        147 kB
      4. screenshot-4.png
        131 kB
      5. screenshot-5.png
        77 kB

        Activity

        Mandeep Hayher created issue -
        Mandeep Hayher made changes -
        Field Original Value New Value
        Attachment screenshot-1.jpg [ 12354 ]
        Mandeep Hayher made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Hide
        Mandeep Hayher added a comment -

        Test case available at 'C:\repo\qa\trunk\Regression-Icefaces2\Nightly\ICE-2150'

        Show
        Mandeep Hayher added a comment - Test case available at 'C:\repo\qa\trunk\Regression-Icefaces2\Nightly\ ICE-2150 '
        Ken Fyten made changes -
        Summary Calendar component not displayed properly inside <ice:panelGrid> <center> <ice:panelGroup> Compat. Calendar component not displayed properly inside <ice:panelGrid> <center> <ice:panelGroup>
        Salesforce Case []
        Fix Version/s 2.0-Beta [ 10231 ]
        Assignee Ken Fyten [ ken.fyten ] Yip Ng [ yip.ng ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2
        yip.ng made changes -
        Attachment screenshot-2.png [ 12389 ]
        yip.ng made changes -
        Attachment screenshot-3.png [ 12390 ]
        Hide
        yip.ng added a comment -

        Nothing to do with calendar component. It's the way the framework renders the <center> tag. In trunk, the <center> tags are rendered correctly. See screenshot-2. In compat, the <center> tags are rendered out of place. The table rows are also messed up as a side effect. See screenshot-3

        Show
        yip.ng added a comment - Nothing to do with calendar component. It's the way the framework renders the <center> tag. In trunk, the <center> tags are rendered correctly. See screenshot-2. In compat, the <center> tags are rendered out of place. The table rows are also messed up as a side effect. See screenshot-3
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Yip Ng [ yip.ng ] Greg Dick [ greg.dick ]
        Ken Fyten made changes -
        Comment [ This might be related to the recent changes in our escaping support? ]
        Hide
        Ken Fyten added a comment -

        Looks like the facelets parser is messing with the <center> tag markup, and then the browser DOM fixer is moving them around.

        Try <ui:debug> on the page, examine the component tree to see if the center tags are siblings of the panelGroup (instead of parent of the panelGroup). If it is, then that confirms that this is caused Facelets parser treats none JSF tags as text, not tags that can hierarchy.

        If this issue is verified, we'll need a new JIRA to add a compat mode config. to support treating HTML tags as tags in the DOM hierarchy.

        Another test is to modify the test page markup to put the <center> tag inside panelGroup, which should work correctly.

        Show
        Ken Fyten added a comment - Looks like the facelets parser is messing with the <center> tag markup, and then the browser DOM fixer is moving them around. Try <ui:debug> on the page, examine the component tree to see if the center tags are siblings of the panelGroup (instead of parent of the panelGroup). If it is, then that confirms that this is caused Facelets parser treats none JSF tags as text, not tags that can hierarchy. If this issue is verified, we'll need a new JIRA to add a compat mode config. to support treating HTML tags as tags in the DOM hierarchy. Another test is to modify the test page markup to put the <center> tag inside panelGroup, which should work correctly.
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Greg Dick [ greg.dick ] Yip Ng [ yip.ng ]
        yip.ng made changes -
        Attachment screenshot-4.png [ 12397 ]
        Hide
        yip.ng added a comment -

        Yes, they are siblings. See screenshot-4.

        Show
        yip.ng added a comment - Yes, they are siblings. See screenshot-4.
        yip.ng made changes -
        Attachment screenshot-5.png [ 12398 ]
        Hide
        yip.ng added a comment -

        Moving <center> tag inside group panel worked. See screenshot-5.

        Show
        yip.ng added a comment - Moving <center> tag inside group panel worked. See screenshot-5.
        Hide
        yip.ng added a comment -

        Changes checked in.

        Show
        yip.ng added a comment - Changes checked in.
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mandeep Hayher added a comment -

        Verified successfully using updated test-case.
        Glimmer revision# 21674
        Server: Tomcat6
        Browser: FF3.6

        Show
        Mandeep Hayher added a comment - Verified successfully using updated test-case. Glimmer revision# 21674 Server: Tomcat6 Browser: FF3.6
        Hide
        Ken Fyten added a comment -

        Follow-up JIRA created to possibly support making UIInstruction tags be their own components: http://jira.icefaces.org/browse/ICE-5806.

        Show
        Ken Fyten added a comment - Follow-up JIRA created to possibly support making UIInstruction tags be their own components: http://jira.icefaces.org/browse/ICE-5806 .
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2

          People

          • Assignee:
            yip.ng
            Reporter:
            Mandeep Hayher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: