ICEfaces
  1. ICEfaces
  2. ICE-5712

sparkle generator leave Meta compilation to sparkle ant script

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When running the dist target on the generator ant script, it compiles the sparkle components' Meta classes, and then packages those .class files into the generator jar. Perhaps we should just have the generator ant script only compile the generator. The component ant script could compile the Meta classes, leaving them out of the generator jar.

        Activity

        Mark Collette created issue -
        Hide
        Ken Fyten added a comment -

        Adnan, please review this issue and comment as to whether there is a technical reason that the meta classes are compiled with the generator itself, etc.

        Show
        Ken Fyten added a comment - Adnan, please review this issue and comment as to whether there is a technical reason that the meta classes are compiled with the generator itself, etc.
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 2.0-Alpha3 [ 10032 ]
        Security Private [ 10001 ]
        Assignee Adnan Durrani [ adnan.durrani ]
        Mark Collette made changes -
        Salesforce Case []
        Description When running the dist target on the generator ant script, it compiles the sparkle components' Meta classes, and then packages those .class files into the generator jar. Perhaps we should just have the generator ant script only compile the generator. The sparkle ant script could compile the Meta classes, leaving them out of the generator jar.
        When running the dist target on the generator ant script, it compiles the sparkle components' Meta classes, and then packages those .class files into the generator jar. Perhaps we should just have the generator ant script only compile the generator. The component ant script could compile the Meta classes, leaving them out of the generator jar.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #21415 Thu May 13 17:09:19 MDT 2010 mark.collette ICE-5677 : sparkle generator compile handler and tag source later
        ICE-5712 : sparkle generator leave Meta compilation to sparkle ant script
        Files Changed
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/build.xml
        Commit graph MODIFY /icefaces/scratchpads/sparkle/component/build.xml
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/src/org/icefaces/generator/xmlbuilder/FacesConfigBuilder.java
        Commit graph ADD /icefaces/scratchpads/sparkle/generator/src/org/icefaces/component/annotation
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/src/org/icefaces/generator/FileWriter.java
        Commit graph DEL /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/annotation
        Commit graph ADD /icefaces/scratchpads/sparkle/generator/src/org/icefaces/component
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/src/org/icefaces/generator/TagClassGenerator.java
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/src/org/icefaces/generator/ComponentHandlerGenerator.java
        Commit graph MODIFY /icefaces/scratchpads/sparkle/generator/src/org/icefaces/generator/ComponentClassGenerator.java
        Mark Collette made changes -
        Assignee Adnan Durrani [ adnan.durrani ] Mark Collette [ mark.collette ]
        Hide
        Mark Collette added a comment -

        Solved ICE-5677 and ICE-5712 together, by mapping out the complete sequence of the sparkle generator and components builds, then reordering the sequence of target building to match dependencies, moved generated files into separate locations to facilitate resequenced build, and reorganising which ant scripts were responsible for which targets.

        Ran into technical difficulties having code generation ran from component ant script, so created component ant target that passed through to generator ant target for generation.

        Subversion 21415

        Show
        Mark Collette added a comment - Solved ICE-5677 and ICE-5712 together, by mapping out the complete sequence of the sparkle generator and components builds, then reordering the sequence of target building to match dependencies, moved generated files into separate locations to facilitate resequenced build, and reorganising which ant scripts were responsible for which targets. Ran into technical difficulties having code generation ran from component ant script, so created component ant target that passed through to generator ant target for generation. Subversion 21415
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 2.0-Beta [ 10231 ]
        Fix Version/s 2.0-Alpha3 [ 10032 ]
        Ken Fyten made changes -
        Fix Version/s 2.0-Beta2 [ 10242 ]
        Fix Version/s 2.0-Beta1 [ 10231 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Collette
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: