ICEfaces
  1. ICEfaces
  2. ICE-5671

Logic to detect navigation does not work if the viewID does not change.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2 JSF 2

            Description

            We currently have a mechanism for determining whether or not navigation has occurred during the JSF lifecycle which relies on the view id changing. However, some navigation use cases are of a "loopback" style where navigation has occurred back to the original page and the view id does not change.

              Activity

              Ascending order - Click to sort in descending order
              Deryk Sinotte created issue -
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21350 Thu Apr 29 16:29:05 MDT 2010 deryk.sinotte ICE-5671: adjust navigation detection to use a View attribute rather than detecting if the view id has changed
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/DetectNavigationPhaseListener.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21360 Tue May 04 10:35:30 MDT 2010 deryk.sinotte ICE-5671: marker added after RESTORE_VIEW phase rather than before INVOKE_APPLICATION to cover more use cases
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/DetectNavigationPhaseListener.java
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I modified the logic so that it now looks for a marker in the view map rather than detecting if the view ID has changed. If the view map does not contain the marker, then we assume that the view has changed and navigation has occurred. We also now add the marker after the RESTORE_VIEW phase so that the marker is present in cases where INVOKE_APPLICATION is not invoked.

              Show
              Deryk Sinotte added a comment - I modified the logic so that it now looks for a marker in the view map rather than detecting if the view ID has changed. If the view map does not contain the marker, then we assume that the view has changed and navigation has occurred. We also now add the marker after the RESTORE_VIEW phase so that the marker is present in cases where INVOKE_APPLICATION is not invoked.
              Deryk Sinotte made changes -
              Field Original Value New Value
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 2.0-Alpha3 [ 10032 ]
              Resolution Fixed [ 1 ]
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21370 Thu May 06 13:46:03 MDT 2010 deryk.sinotte ICE-5671: additional logic to check for postbacks via partial page renders to avoid full page updates in those cases
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Re-opening because postbacks should not be considered navigation during Ajax requests.

              Show
              Deryk Sinotte added a comment - Re-opening because postbacks should not be considered navigation during Ajax requests.
              Deryk Sinotte made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Added a check for postback on Ajax requests to avoid doing full page updates in those cases.

              Show
              Deryk Sinotte added a comment - Added a check for postback on Ajax requests to avoid doing full page updates in those cases.
              Deryk Sinotte made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: