ICEfaces
  1. ICEfaces
  2. ICE-5670

Javascript insertion should use startElement to create DOM structures

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Invalid
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEFaces 2,0

            Description

            The currently approved method for inserting javascript into the response is to create an instance of UIOutput that starts a script element, modifies attributes, writes the javascript as a text child, and closes the Element. The current method creates an UIOutput object to write a textNode which consists of the complete script String. This makes it very difficult to appropriately escape the <script> tags in the response writer

              Activity

              Ascending order - Click to sort in descending order
              Greg Dick created issue -
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21335 Wed Apr 28 07:39:48 MDT 2010 greg.dick ICE-5670 Create script element with the javascript as a text node
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/EnterKeySubmit.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/RedirectSubmit.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21339 Wed Apr 28 11:11:40 MDT 2010 greg.dick ICE-5670 corrected method signature and extracted to common class
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/EnterKeySubmit.java
              Commit graph ADD /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/ScriptWriter.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/RedirectSubmit.java
              Hide
              Permalink
              Ted Goddard added a comment -

              In the basic demo, it looks like a <span> tag is being produced rather than a <script> tag.

              Show
              Ted Goddard added a comment - In the basic demo, it looks like a <span> tag is being produced rather than a <script> tag.
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Greg Dick [ greg.dick ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Please update this case with any relevant info and resolve.

              Show
              Deryk Sinotte added a comment - Please update this case with any relevant info and resolve.
              Deryk Sinotte made changes -
              Salesforce Case []
              Fix Version/s 2.0-Alpha3 [ 10032 ]
              Hide
              Permalink
              Greg Dick added a comment -

              We decided to leave this as is.

              Show
              Greg Dick added a comment - We decided to leave this as is.
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Invalid [ 6 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: