ICEfaces
  1. ICEfaces
  2. ICE-5661

ICEfaces script elements added to the form change location causing unnecessary updates

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 2 JSF 2

            Description

            Using system event listeners, we automatically attach the following two <script> elements to h:forms:

            <script type='text/javascript'>ice.captureSubmit('form');</script>
            <script type='text/javascript'>ice.captureEnterKey('form');</script>

            During the initial rendering of the page, these elements are typically at the bottom of the form markup. However, during the next render phase, they are placed at the top of the form, causing the DOM diff to identify more updates than are really necessary.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21303 Fri Apr 23 14:06:23 MDT 2010 deryk.sinotte ICE-5661: place form scripts specifically as the first children to avoid them jumping around
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/EnterKeySubmit.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/RedirectSubmit.java
              Deryk Sinotte created issue -
              Deryk Sinotte made changes -
              Field Original Value New Value
              Salesforce Case []
              Component/s Framework [ 10013 ]
              Fix Version/s 2.0-Alpha3 [ 10032 ]
              Affects Version/s 2.0-Alpha2 [ 10214 ]
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I've changed how we add the scripts as children of the forms from:

              form.getChildren().add(out);

              to and indexed version

              form.getChildren().add(0,out);

              so they should always appear in the same location.

              Show
              Deryk Sinotte added a comment - I've changed how we add the scripts as children of the forms from: form.getChildren().add(out); to and indexed version form.getChildren().add(0,out); so they should always appear in the same location.
              Deryk Sinotte made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Deryk Sinotte
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: