ICEfaces
  1. ICEfaces
  2. ICE-5604

Compat: Focus is lost after submission on input component

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha2
          • Fix Version/s: 2.0-Beta1, 2.0.0
          • Component/s: None
          • Labels:
            None
          • Environment:
            Windows 7, Windows XP Professional, IE 8, Firefox 3.6.3

            Description

            After submition on component (press ENTER key), focus doesn't stay on the same place but the focus is lost.

            Components, where the problem was noticed: TabPanel, Collapsible panel, Tree

            The problem is probably on every submition on every component. (IceFaces 1.8.2, 1.8.2a are correct)

              Activity

              Ascending order - Click to sort in descending order
              Miroslav Karsulin created issue -
              Hide
              Permalink
              Ken Fyten added a comment -

              Please test using latest GLimmer to see if you can reproduce. The auctionMonitor bidding /chat and compat showcase submit buttons would be good candidates.

              Show
              Ken Fyten added a comment - Please test using latest GLimmer to see if you can reproduce. The auctionMonitor bidding /chat and compat showcase submit buttons would be good candidates.
              Ken Fyten made changes -
              Field Original Value New Value
              Salesforce Case []
              Assignee Mandeep Hayher [ mandeep.hayher ]
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Glimmer revision# 21611
              Server: Tomcat6
              Browser: FF3.6

              Focus problem CAN be reproduced on Tree component.

              Collapsible panel has NO focus issues.

              Static Tabset has No focus issue.
              It does have tabindex issues: cannot tab into individual radio buttons. Cannot tab into check boxes (need to select some checkbox by clicking before using tab key)
              Selection component page has similar tabindex issues too.

              Dynamic Tabset has NO focus issues.

              Show
              Mandeep Hayher added a comment - Glimmer revision# 21611 Server: Tomcat6 Browser: FF3.6 Focus problem CAN be reproduced on Tree component. Collapsible panel has NO focus issues. Static Tabset has No focus issue. It does have tabindex issues: cannot tab into individual radio buttons. Cannot tab into check boxes (need to select some checkbox by clicking before using tab key) Selection component page has similar tabindex issues too. Dynamic Tabset has NO focus issues.
              Mandeep Hayher made changes -
              Assignee Mandeep Hayher [ mandeep.hayher ] Ken Fyten [ ken.fyten ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Need to ensure that the 1.8 focus support apis, etc. are working in compat also. Please investigate.

              Show
              Ken Fyten added a comment - Need to ensure that the 1.8 focus support apis, etc. are working in compat also. Please investigate.
              Ken Fyten made changes -
              Summary Focus is lost after submition on component. Compat: Focus is lost after submission on input component
              Salesforce Case []
              Fix Version/s 2.0-Beta [ 10231 ]
              Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21635 Thu Jun 03 09:12:34 MDT 2010 mircea.toma ICE-5604 Send ice.focus parameter on every submit.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/javascript/submit.js
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/javascript/focus.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21636 Thu Jun 03 09:25:18 MDT 2010 mircea.toma ICE-5604 Send back eval command to re-apply focus.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
              Hide
              Permalink
              Mircea Toma added a comment -

              It seems that ice.focus parameter was not sent during submit. The fix change iceSubmit/iceSubmitPartial to send the ID of the currently focused component.

              Show
              Mircea Toma added a comment - It seems that ice.focus parameter was not sent during submit. The fix change iceSubmit/iceSubmitPartial to send the ID of the currently focused component.
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Changed CompatDOMPartialViewContext to send the code needed to re-apply focus on the element. This ensures that the element retains its focus even after an update was applied.

              Show
              Mircea Toma added a comment - - edited Changed CompatDOMPartialViewContext to send the code needed to re-apply focus on the element. This ensures that the element retains its focus even after an update was applied.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #21640 Thu Jun 03 13:56:16 MDT 2010 mircea.toma ICE-5604 Stop sending focus when ice.focus=undefined is received.
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Miroslav Karsulin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: