ICEfaces
  1. ICEfaces
  2. ICE-5593

Validation firing on non-required input components

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-GA
    • Fix Version/s: 1.8.2-EE-GA_P02
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      -

      Description

      The attached test case has a dataTable with 3 selectOneRadio components. The row level object of the table has a boolean attribute bound to the required attribute of the selectOnRadio component. In this case, only the first selectOneRadio is required. Here are the steps to reproduce the issue:

      1. Leave all fields unchecked and click submit. The first selectOneRadio will fire a validation error indicating the value is required, which is correct.
      2. If you now check the first selectOneRadio and click the submit button, the two non-required selectOneRadio components will fire validation errors indicating they are required fields. This is incorrect as the required attribute of each is still set to false.

        Activity

        Tyler Johnson created issue -
        Tyler Johnson made changes -
        Field Original Value New Value
        Attachment sc9079.war [ 12285 ]
        Tyler Johnson made changes -
        Salesforce Case []
        Description The attached test case has a dataTable with 3 selectOneRadio components. The row level object of the table has a boolean attribute bound to the required attribute of the selectOnRadio component. In this case, only the first selectOneRadio is required. Here are the steps to reproduce the issue:

        1. Leave all fields unchecked and click submit. The first selectOneRadio will fire a validation error indicating the value is required, which is correct
        2. If you now check the first selectOneRadio and click the submit button, the two non-required selectOneRadio components will fire validation errors indicating they are required fields. This is incorrect as required attribute is still set to false for both selectOneRadio components.
        The attached test case has a dataTable with 3 selectOneRadio components. The row level object of the table has a boolean attribute bound to the required attribute of the selectOnRadio component. In this case, only the first selectOneRadio is required. Here are the steps to reproduce the issue:

        1. Leave all fields unchecked and click submit. The first selectOneRadio will fire a validation error indicating the value is required, which is correct.
        2. If you now check the first selectOneRadio and click the submit button, the two non-required selectOneRadio components will fire validation errors indicating they are required fields. This is incorrect as the required attribute of each is still set to false.
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Hide
        Mark Collette added a comment -

        Each table row renders an asterisk * if that row is required, and it's only rendered for the first row, so it looked like the bottom two rows should know they're not required. That's what makes it so puzzling.

        Show
        Mark Collette added a comment - Each table row renders an asterisk * if that row is required, and it's only rendered for the first row, so it looked like the bottom two rows should know they're not required. That's what makes it so puzzling.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #21177 Wed Apr 07 17:18:08 MDT 2010 adnan.durrani Fix for ICE-5593(Validation firing on non-required input components)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/UISeries.java
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Adnan Durrani added a comment -

        Stale code removed.
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelseries\UISeries.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelseries\UISeries.java
        Completed: At revision: 21177

        Show
        Adnan Durrani added a comment - Stale code removed. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelseries\UISeries.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelseries\UISeries.java Completed: At revision: 21177
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Priority P1
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Priority P1
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: