ICEfaces
  1. ICEfaces
  2. ICE-5589

should render proper html when using render.auto context param

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-Alpha3
    • Fix Version/s: 2.0-Alpha3, 2.0.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      jsf2.0, ICEfaces-2.0

      Description

      htmlunit tests with jsf2.0 tests the ability to render properly jsp pages. With the following context-param, this feature should also be available with ICEfaces-2.0:-
          <context-param>
              <param-name>org.icefaces.render.auto</param-name>
              <param-value>false</param-value>
          </context-param>

        Issue Links

          Activity

          Judy Guglielmin created issue -
          Judy Guglielmin made changes -
          Field Original Value New Value
          Link This issue depends on ICE-4950 [ ICE-4950 ]
          Hide
          Judy Guglielmin added a comment -

          with rev. 2163, all markup is good except:-
          sessionID is being attached to action with addition of ICEfaces libraries (not there when ICEfaces is not present):-
          for example:-
          with ICEfaces
          action="/jsf-systest/faces/taglib/commandButton_param_test.jsp;jsessionid=3c6a61379a67da7000051bf0bce8"
          without ICEfaces:-
          action="/jsf-systest/faces/taglib/commandButton_param_test.jsp"

          also extra <span> tags with id's are being inserted in the ICEfaces test with extra id's and the id's are now preceded by __ for each of these span Id's. None of these are present in the tests without ICEfaces.

          Also extra with the ICEfaces tests is the following addition to the markup:-
          <script type='text/javascript'>ice.captureSubmit('form01');</script>

          These things may be required for push even though ICEfaces

          Show
          Judy Guglielmin added a comment - with rev. 2163, all markup is good except:- sessionID is being attached to action with addition of ICEfaces libraries (not there when ICEfaces is not present):- for example:- with ICEfaces action="/jsf-systest/faces/taglib/commandButton_param_test.jsp;jsessionid=3c6a61379a67da7000051bf0bce8" without ICEfaces:- action="/jsf-systest/faces/taglib/commandButton_param_test.jsp" also extra <span> tags with id's are being inserted in the ICEfaces test with extra id's and the id's are now preceded by __ for each of these span Id's. None of these are present in the tests without ICEfaces. Also extra with the ICEfaces tests is the following addition to the markup:- <script type='text/javascript'>ice.captureSubmit('form01');</script> These things may be required for push even though ICEfaces
          Judy Guglielmin made changes -
          Link This issue blocks ICE-4950 [ ICE-4950 ]
          Judy Guglielmin made changes -
          Link This issue depends on ICE-4950 [ ICE-4950 ]
          Hide
          Judy Guglielmin added a comment -

          Note that with rev 21163, all facelets tests pass the htmlunit tests.

          Show
          Judy Guglielmin added a comment - Note that with rev 21163, all facelets tests pass the htmlunit tests.
          Hide
          Judy Guglielmin added a comment -

          correction to above*** the sessionid is included with the standard jsf testing (not the ICEfaces pages)
          All the "golden" tests show the sessionid as part of the action of the page
          The ICEfaces pages do not show this.
          One other difference is the autocomplete="off" attribute on the <input> fields for the ViewState input tag that is of type="hidden". This is not present when ICEfaces jars are included.

          Show
          Judy Guglielmin added a comment - correction to above*** the sessionid is included with the standard jsf testing (not the ICEfaces pages) All the "golden" tests show the sessionid as part of the action of the page The ICEfaces pages do not show this. One other difference is the autocomplete="off" attribute on the <input> fields for the ViewState input tag that is of type="hidden". This is not present when ICEfaces jars are included.
          Hide
          Ken Fyten added a comment -

          To clarify, this issue is not specific to JSP, correct? ICEfaces 2.0 only supports Facelets.

          Show
          Ken Fyten added a comment - To clarify, this issue is not specific to JSP, correct? ICEfaces 2.0 only supports Facelets.
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 2.0-Alpha3 [ 10032 ]
          Assignee Judy Guglielmin [ judy.guglielmin ]
          Hide
          Judy Guglielmin added a comment -

          changes made by Ted and Deryk to DOMResponseWriter allows jsp/golden tests to all pass.

          Show
          Judy Guglielmin added a comment - changes made by Ted and Deryk to DOMResponseWriter allows jsp/golden tests to all pass.
          Judy Guglielmin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22686 Tue Oct 19 10:28:32 MDT 2010 judy.guglielmin ICE-5589 update tlddoc properties, ICE-5276 update tlddoc properties. Sample xhtml for tes app for pushbuttonSam was missing
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonMeta.java
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/pushbuttonSam.xhtml
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22694 Tue Oct 19 23:52:49 MDT 2010 judy.guglielmin ICE-5589 update tlddoc properties, ICE-5276 update tlddoc properties. Use jsf value for yui label in pushbutton and jsf label for yui arialabel. fix checkboxButton rime for labelPosition="left".
          Files Changed
          Commit graph DEL /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/skins/rime/button-skin.css
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonMeta.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/resources/org.icefaces.component.pushbutton/pushbutton.js
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/pushbuttonSam.xhtml
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/skins/rime/button.css
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/skins/rime/checkboxButton.css
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/pushbuttonRime.xhtml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22698 Wed Oct 20 11:23:44 MDT 2010 judy.guglielmin ICE-5589 update tlddoc properties, ICE-5276 update tlddoc properties. finish standard style and styleClass support for both buttons. Test more on value vs label on pushbutton.
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonMeta.java
          Commit graph ADD /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/skins/rime/bullet.gif
          Commit graph MODIFY /icefaces/scratchpads/sparkle/showcase/test/web/buttons/pushbuttonSam.xhtml
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
          Commit graph ADD /icefaces/scratchpads/sparkle/showcase/test/web/buttons/immediateTest.xhtml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22700 Wed Oct 20 13:08:48 MDT 2010 judy.guglielmin ICE-5589, ICE-5276 remove System.out statements
          Files Changed
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/pushbutton/PushButtonRenderer.java
          Commit graph MODIFY /icefaces/scratchpads/sparkle/component/src/org/icefaces/component/checkboxbutton/CheckboxButtonRenderer.java
          Ken Fyten made changes -
          Fix Version/s 2.0.0 [ 10230 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Judy Guglielmin
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: