Up and down arrow key support added to navigate between rows and space bar support added to select the row. The Enter key also can be used to select a row.

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Completed: At revision: 20508

EE branch.
Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\bridge\lib\extras\extras.js
Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\bridge\lib\extras\extras.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Completed: At revision: 20509

Thanks. It resolve also ICE-1694

Some quick clicks on datatable rows generate this error on one of new lines of code.

Stacktrace :java.lang.RuntimeException: wrapped Exception: java.lang.NullPointerException
at com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:176)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at com.icesoft.faces.webapp.xmlhttp.BlockingServlet.service(BlockingServlet.java:56)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:433)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454)
at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.NullPointerException
at javax.faces.component.UIComponentBase$AttributesMap.put(UIComponentBase.java:1656)
at javax.faces.component.UIComponentBase$AttributesMap.put(UIComponentBase.java:1526)
at com.icesoft.faces.component.ext.RowSelector.processDecodes(RowSelector.java:342)
at com.icesoft.faces.component.ext.HtmlDataTable.processKids(HtmlDataTable.java:331)
at com.icesoft.faces.component.ext.HtmlDataTable.iterate(HtmlDataTable.java:286)
at com.icesoft.faces.component.panelseries.UISeries.processDecodes(UISeries.java:316)

Request Change: Pressing the up and down arrow automatically selects the next row without the need to press the space bar in single selection mode.

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\bridge\lib\extras\extras.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Completed: At revision: 20647

Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\bridge\lib\extras\extras.js
Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\bridge\lib\extras\extras.js
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
Completed: At revision: 20648

Patch for above NPE

RowSelector.java

Row 341

//install selected row on the dataTable, helps in sending focus request when row was selected.
> if (selectedRows!=null)
dataTable.getAttributes().put(SELECTED_ROW, selectedRows);

BTW
Key Up/Down doesn't works in scrollable table

Thanks Krashan, I'll apply this patch and look into the scrollable table.

Null check added.
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Completed: At revision: 20676

Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
Completed: At revision: 20677

Tested on 1.8.2-ee revision #20705 with Tomcat 6 using showcase jsp and facelets

Test results:

a) single mode:

• tested successfully using FF3.5
• In IE8, up/down arrow can only move one row above or below, then back to the row it was

b) multiple mode: Tested with success on both FF3.5 and IE8

c) enhanced multiple:

• multiple rows can be selected without problem, but every time when the Enter key is hit to make a selection, a new page will be opened at the same time. It happens to both IE8 and FF3.5

Testing steps:

• in Row Selection demo, check one of the radio boxes to select single/multiple/enhanced mode
• use Tab key to get to the data table rows, then try the up/down arrow keys
• in single mode, one row will be selected right away while the up/down arrow key going through it
• in multiple/enhanced mode, Enter key is needed to help with the selection

Adnan, let me know if I need reopen the case and re-assign it back to you. Thanks.

a) single mode:

• In IE8, up/down arrow can only move one row above or below, then back to the row it was

It fixed under the following JIRA:
http://jira.icefaces.org/browse/ICE-5415

c) enhanced multiple:

• multiple rows can be selected without problem, but every time when the Enter key is hit to make a selection, a new page will be opened at the same time. It happens to both IE8 and FF3.5

We did not added the enter key support to selecting a row, it comes with the browser. The valid test would be to test with shift + space. The shift and enter is browser chortcut to open a link in a new window.

Adnan, thanks so much for the clarification. Re-tested on ICEfaces-1.8.2-ee revision 20744 using FF8 and FF3.5

a) single/multiple mode: works perfectly on both FF3.5 and IE8
b) enhanced multiple: Shift + space does not always work (happens to IE8 and FF3.5)

Thera are small backward incompability.
If datable cell contain very long text then in IE6 anchor from rowselector wraps cell content (looks like new empty line before text)

Workaround - around line761
< anchor.appendChild(domContext.createTextNode("<img src='"+ CoreUtils.resolveResourceURL(facesContext,
"/xmlhttp/css/xp/css-images/spacer.gif") + "' />"));
fix
> anchor.appendChild(domContext.createTextNode("<img style='width:0' src='"+ CoreUtils.resolveResourceURL(facesContext,
"/xmlhttp/css/xp/css-images/spacer.gif") + "' />"));

In attachment image with width bug from IE6

Thanks Krashan, the fix has been added to relvant style class.

Trunk = Completed: At revision: 20815
EE = Completed: At revision: 20816

Row selector regression failures found on CEfaces-1.8.2-ee revision: 20826

• ICE-4288: rowSelector, 'clickListener' and 'clickAction' attributes are ignored when using facelets
• ICE-1445: Check the Immediate box, row selection does not work at all

ICE-5460 fixes them.

ICE-4288 and ICE-1445 have been verified successfully with the new fix (ICEfaces-ee-1.8.2 revision 20843)
Tested on Tomcat 5 + FF3.5 and IE8.

Thanks, Adnan. Close it!

regression of
"ICE-4288: rowSelector, 'clickListener' and 'clickAction' attributes are ignored when using facelets"
is still present in 1.8.3 version, ICE-5460 fixes them only in EE version, plz commit fix to 1.8.3 version to be row selector navigation usable again
Thanks