ICEfaces
  1. ICEfaces
  2. ICE-5223

Buttons in the main page under modal popup gets activated by accesskey sequence (Alt+Shift+accesskey)

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2-EE-GA
          • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            ICEFaces on SuSe Linux, Browser is Firefox 3.5.6 on Windows

            Description

            Scenario: Main page contains a form with few ice:commandButton components. Then, an user action opens a modal popup (ice:panelPopup component). Modal popup has couple of buttons as well. All buttons have their accesskey attributes set.

            Issue: Typing accesskey sequence for each button (Alt+Shift+accesskey) activates that button, irrespective of whether it's in modal popup or main page under popup

            Expected: accesskey sequences for buttons in main page should have been ignored. (similar to how mouse clicks are ignored.)

            Impact: We heavily use ice:panelPopup and this issue makes accesskey attribute of ice:commandButton almost unusable.

              Activity

              Ascending order - Click to sort in descending order
              Abhijit Jere created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [5007000000D6bwK]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Can you use the same technique for the modal popup that we use for the BlockUIOnSubmit keyboard blocking?

              Show
              Ken Fyten added a comment - Can you use the same technique for the modal popup that we use for the BlockUIOnSubmit keyboard blocking?
              Ken Fyten made changes -
              Assignee Priority P2
              Assignee Mircea Toma [ mircea.toma ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23025 Wed Nov 03 14:48:05 MDT 2010 mircea.toma ICE-5223 Store and disable the onkey* and onclick callbacks belonging to the elements located outside of the popup container element. Restore the callback once the popup is closed.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23027 Wed Nov 03 15:42:44 MDT 2010 mircea.toma ICE-5223 Clear the list with rollbacks.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Blocked any keyboard interaction with the elements located underneath the modal popup. The strategy chosen was to store and disable the onkey* and onclick callbacks belonging to the elements located outside of the popup container element. Once the popup is closed the callbacks are restored.

              The disabling of the 'onclick' handler specifically solves this issue, the 'click' event generated by an access key invocation is ignored when the popup is on.

              Show
              Mircea Toma added a comment - Blocked any keyboard interaction with the elements located underneath the modal popup. The strategy chosen was to store and disable the onkey* and onclick callbacks belonging to the elements located outside of the popup container element. Once the popup is closed the callbacks are restored. The disabling of the 'onclick' handler specifically solves this issue, the 'click' event generated by an access key invocation is ignored when the popup is on.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Need to apply this improved approach to the icefaces2 compat popup as well, and also the ICEfaces 2 blockUIOnSubmit.

              Show
              Ken Fyten added a comment - Need to apply this improved approach to the icefaces2 compat popup as well, and also the ICEfaces 2 blockUIOnSubmit.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Fix Version/s 1.8.3 [ 10211 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23042 Fri Nov 05 09:50:04 MDT 2010 mircea.toma ICE-5223 Blocked any keyboard interaction with the elements located underneath the modal popup.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Applied fixes to icefaces2.0/compat code as well.

              Show
              Mircea Toma added a comment - Applied fixes to icefaces2.0/compat code as well.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Mircea, I'm seeing a likely regression from this change in component-showcase. If you view the popup panel demo, view a modal dialog, close it, you can't click on the Desc. or Source tabs now, or select another demo link from the nav panel on the left side.

              Show
              Ken Fyten added a comment - Mircea, I'm seeing a likely regression from this change in component-showcase. If you view the popup panel demo, view a modal dialog, close it, you can't click on the Desc. or Source tabs now, or select another demo link from the nav panel on the left side.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2 P1
              Hide
              Permalink
              Isuru Perera added a comment -

              Hi Ken, yes.. I also noticed that issue. Javascript stops working after opening a modal popup or a confirmation popup.

              Show
              Isuru Perera added a comment - Hi Ken, yes.. I also noticed that issue. Javascript stops working after opening a modal popup or a confirmation popup.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23091 Wed Nov 10 14:54:16 MST 2010 mircea.toma ICE-5223 Rename the try/catch variable to avoid naming conflicts.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23092 Wed Nov 10 14:56:41 MST 2010 mircea.toma ICE-5223 Rename the try/catch variable to avoid naming conflicts.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #23093 Wed Nov 10 15:15:13 MST 2010 mircea.toma ICE-5223 Block onclick events to avoid having the controls found underneath the overlay to be modified using accesskeys.
              Files Changed
              Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/javascript/blockui.js
              Hide
              Permalink
              Mircea Toma added a comment -

              The issue was caused by the try/catch variable that redefined the 'e' variable holding the element having its callbacks restored. The solution was to rename the try/catch variable to avoid naming conflicts.

              Show
              Mircea Toma added a comment - The issue was caused by the try/catch variable that redefined the 'e' variable holding the element having its callbacks restored. The solution was to rename the try/catch variable to avoid naming conflicts.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Applied fixes to icefaces2.0 blockUI code as well.

              Show
              Mircea Toma added a comment - Applied fixes to icefaces2.0 blockUI code as well.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Abhijit Jere
                • Votes:
                  2 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: