Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.2
-
Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02
-
Component/s: Framework
-
Labels:None
-
Environment:ICEfaces, Liferay
-
ICEsoft Forum Reference:
Description
Occasionally push events will fail to be delivered. SessionRenderer.render() is known to be called but the session appears to be no longer in the group.
This is believed to be due to the WeakReference referring to the sesionID in GroupAsyncRenderer:
if (!contains(object)) {
if (group.add(new WeakReference(object))) {
it is not necessary to retain the sessionID String with only a WeakReference, unlike the previous implementation where a reference to the session object was maintained.
Issue Links
- is duplicated by
-
ICE-4434
Ajax push doesn't work anymore after a page change in liferay portal
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Deryk Sinotte [ deryk.sinotte ] |
This bug does not seem to appear in applications that are using the Renderable API (thereby avoiding the weak reference to the sessionID).
Show
Ted Goddard
added a comment - This bug does not seem to appear in applications that are using the Renderable API (thereby avoiding the weak reference to the sessionID).
This is my assumption:
- Whenever the session is decorated (a lot of frameworks do that), what is added as a WeakReference within the GroupAsyncRenderer's add(Object) method is not the "real" session object but rather the wrapped one which is thrown away and hence becomes weakly reachable and might be removed by the house-keeping mechanism within the GroupAsyncRenderer.
This might be an explanation why push is not working from time to time and a well know workaround is to add the session to a render group more frequently.
Show
Micha Kiener
added a comment - This is my assumption:
Whenever the session is decorated (a lot of frameworks do that), what is added as a WeakReference within the GroupAsyncRenderer's add(Object) method is not the "real" session object but rather the wrapped one which is thrown away and hence becomes weakly reachable and might be removed by the house-keeping mechanism within the GroupAsyncRenderer.
This might be an explanation why push is not working from time to time and a well know workaround is to add the session to a render group more frequently.
As Ted notes, now that we've moved away from relying on sessions and now use session ids, we likely don't require wrapping the key in a WeakReference any longer as it would potentially cause the noted problem if the key itself does not live as long as the session.
Show
Deryk Sinotte
added a comment - As Ted notes, now that we've moved away from relying on sessions and now use session ids, we likely don't require wrapping the key in a WeakReference any longer as it would potentially cause the noted problem if the key itself does not live as long as the session.
| Salesforce Case | [] | |
| Fix Version/s | 1.8.2-EE-GA_P01 [ 10220 ] | |
| Fix Version/s | 1.8.3 [ 10211 ] |
Micha, please let us know whether the code change of removing the WeakReference resolves the problem in your application.
Show
Ted Goddard
added a comment - Micha, please let us know whether the code change of removing the WeakReference resolves the problem in your application.
...or attach a test-case that can be used to reproduce the issue and verify the fix.
| Salesforce Case | [] | |
| Fix Version/s | 1.8.3 [ 10211 ] | |
| Fix Version/s | 1.8.2-EE-GA_P01 [ 10220 ] |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Incomplete [ 4 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #21174 | Wed Apr 07 14:49:28 MDT 2010 | deryk.sinotte | |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
Re-opening to apply fix.
Show
Deryk Sinotte
added a comment - Re-opening to apply fix.
| Resolution | Incomplete [ 4 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| ICEsoft Forum Reference | http://www.icefaces.org/JForum/posts/list/15299.page | |
| Salesforce Case | [5007000000Ap1Nr] |
Applying modified version of the fix that was sent to support customer.
Show
Deryk Sinotte
added a comment - Applying modified version of the fix that was sent to support customer.
| Fix Version/s | 1.8.2-EE-GA_P02 [ 10226 ] | |
| Fix Version/s | 1.8.3 [ 10211 ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee | Deryk Sinotte [ deryk.sinotte ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Assignee Priority | P1 |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Assignee Priority | P1 | |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Assigning to Deryk for dispatch. Micha will potentially provide a test case.