ICEfaces
  1. ICEfaces
  2. ICE-5013

ice:columns creates 1 extra <td> element than number of <th> elements when table is empty, as a result table renders badly

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2
          • Fix Version/s: 1.8.2-EE-Beta, 1.8.2-EE-GA, 1.8.3
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            SUSE Linux 10 (x86_64), ICEFaces 1.8.2

            Description

            This seems to be a regression with 1.8.2.

            ice:columns used inside a ice:dataTable creates 1 extra <td> element than number of <th> elements when table is empty. As a result table renders badly. Screen shot of the table and HTML generated by ICEFaces is attached. Below is the code snippet -

                  <ice:dataTable>
                    <ice:columns>
                      <f:facet name="header">
                        <ice:commandSortHeader>
                          <ice:outputText />
                        </ice:commandSortHeader>
                      </f:facet>
                    </ice:columns>
                    <ice:outputText />
                  </ice:dataTable>

            This problem is not seen if <ice:columns> is replaced by multiple <ice:column> elements, however, this workaround is not useful in our use case, where the file containing this dataTable is a reusable facelet and used by many other pages.
            1. 1.8.2_columns_issue.JPG
              44 kB
            2. screenshot-1.png
              205 kB
            3. screenshot-2.png
              220 kB

              Activity

              Ascending order - Click to sort in descending order
              Abhijit Jere created issue -
              Abhijit Jere made changes -
              Field Original Value New Value
              Attachment 1.8.2_columns_issue.JPG [ 12035 ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 1.8.3 [ 10211 ]
              Assignee Yip Ng [ yip.ng ]
              yip.ng made changes -
              Attachment screenshot-1.png [ 12049 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19444 Mon Oct 19 10:31:53 MDT 2009 yip.ng ICE-5013: Fixed one-off error in calculating no. of columns when table is empty.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              yip.ng made changes -
              Attachment screenshot-2.png [ 12050 ]
              Hide
              Permalink
              yip.ng added a comment -

              Issue caused by one-off error in calculation. Fixed. See screen shots 1 and 2.

              Show
              yip.ng added a comment - Issue caused by one-off error in calculation. Fixed. See screen shots 1 and 2.
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-EE-Beta [ 10215 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-EE-GA [ 10216 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19890 Tue Dec 08 15:08:57 MST 2009 judy.guglielmin ICE-4481 updates TableRenderer for ICE-5013, ICE-4979, ICE-4916, ICE-3943, ICE-4306
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
              Hide
              Permalink
              Joanne Bai added a comment -

              Tested with success on ICEfaces-ee-1.8.2 revision #19954

              Tested on Tomcat 6 + FF3.5 and IE8

              Test app has been committed to repo\qa\trunk\Regression\ICE-5013

              Show
              Joanne Bai added a comment - Tested with success on ICEfaces-ee-1.8.2 revision #19954 Tested on Tomcat 6 + FF3.5 and IE8 Test app has been committed to repo\qa\trunk\Regression\ ICE-5013
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Yip Ng [ yip.ng ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Abhijit Jere
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: