ICEfaces
  1. ICEfaces
  2. ICE-5010

dataPaginator immediate=true partly ignored

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.2-EE-GA, 1.8.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Apache Tomcat, Icefaces 1.8.2, Windows XP/Vista

      Description

      I attached an example project that clearly shows that the validation of the calendar component is fired whenever you click an page number in the dataTable paginator component although the attribute immediate=true is set on it.

      If you set immediate="true" on the ice:dataPaginator it is only applied on the page 'jumper' arrow images [page jumper controller] but not on the navigation of the individual page images [page controller].

      Ugly workaround:
      Set paginator="false" on the dataTable which will just show the page-jumper-controller-images (which are working well with the immediate=true ) not the page-controller-images

        Activity

        Hide
        Jacopo Dell Anno added a comment -

        I have found a solution to this bug.

        I modified DataPaginator in order to transform pages' numbers into a new facet.

        If you wish I can post my sources.

        Hey Admin, if you are interested in this change let me know I will explain my modifications.

        Bye Bye Jacopo from Florence ITALY

        Show
        Jacopo Dell Anno added a comment - I have found a solution to this bug. I modified DataPaginator in order to transform pages' numbers into a new facet. If you wish I can post my sources. Hey Admin, if you are interested in this change let me know I will explain my modifications. Bye Bye Jacopo from Florence ITALY
        Hide
        Ken Fyten added a comment -

        We would be pleased to accept a contribution in this case. Please consult the "How To Contribute" page on .org for details: http://www.icefaces.org/main/community/contribute.iface.

        Show
        Ken Fyten added a comment - We would be pleased to accept a contribution in this case. Please consult the "How To Contribute" page on .org for details: http://www.icefaces.org/main/community/contribute.iface .
        Hide
        Jacopo Dell Anno added a comment - - edited

        First of all, I must say that before may 2009 I have never seen a JSF, only jsp and tag library.
        So my modifications may be incomplete.
        However I found a solution to the problem regarding no validation required during the navigation from a page to another by clicking on the specific page number.
        The original renderer made use of HTML DOM to build the linked pages.

        I created a new facet "paginax" (x page in italian) that creates an HtmlCommandLink.

        -> HtmlCommandLink link = (HtmlCommandLink) getLinkPaginaX(facesContext, scroller, facetName, idx);

        This seams to work fine.

        Below how to call the modified DataPaginator tag.

        <ice:dataPaginator for="#

        {targetTable}

        " renderFacetsIfSinglePage="false"
        paginatorMaxPages="#

        {maxPages}

        " immediate="true" paginator="true">

        <f:facet name="previous">
        <ice:graphicImage url="images/arrow-previous.gif" title="PREVIOUS" />
        </f:facet>

        <f:facet name="paginax">&nbsp;</f:facet>

        <f:facet name="next">
        <ice:graphicImage url="images/arrow-next.gif" title="NEXT" />
        </f:facet>
        </ice:dataPaginator>

        my source at -> http://jira.icefaces.org/secure/attachment/12095/datapaginator.zip

        Show
        Jacopo Dell Anno added a comment - - edited First of all, I must say that before may 2009 I have never seen a JSF, only jsp and tag library. So my modifications may be incomplete. However I found a solution to the problem regarding no validation required during the navigation from a page to another by clicking on the specific page number. The original renderer made use of HTML DOM to build the linked pages. I created a new facet "paginax" (x page in italian) that creates an HtmlCommandLink. -> HtmlCommandLink link = (HtmlCommandLink) getLinkPaginaX(facesContext, scroller, facetName, idx); This seams to work fine. Below how to call the modified DataPaginator tag. <ice:dataPaginator for="# {targetTable} " renderFacetsIfSinglePage="false" paginatorMaxPages="# {maxPages} " immediate="true" paginator="true"> <f:facet name="previous"> <ice:graphicImage url="images/arrow-previous.gif" title="PREVIOUS" /> </f:facet> <f:facet name="paginax">&nbsp;</f:facet> <f:facet name="next"> <ice:graphicImage url="images/arrow-next.gif" title="NEXT" /> </f:facet> </ice:dataPaginator> my source at -> http://jira.icefaces.org/secure/attachment/12095/datapaginator.zip
        Hide
        Adnan Durrani added a comment -

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
        Completed: At revision: 19732

        Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
        Completed: At revision: 19733

        Show
        Adnan Durrani added a comment - Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 19732 Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java Completed: At revision: 19733
        Hide
        Joanne Bai added a comment -

        Fix verified successfully on ICEfaces-1.8.2-EE build 2

        Verified on Tomcat 6 using FF3.5 and IE8

        Test app is checked into repo\qa\trunk\Regression\ICE-5010

        Show
        Joanne Bai added a comment - Fix verified successfully on ICEfaces-1.8.2-EE build 2 Verified on Tomcat 6 using FF3.5 and IE8 Test app is checked into repo\qa\trunk\Regression\ ICE-5010

          People

          • Assignee:
            Unassigned
            Reporter:
            Patrick Dobler
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: