ICEfaces
  1. ICEfaces
  2. ICE-5006

Limit individual users to a maximum number of views

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2
    • Fix Version/s: 1.8.2-EE-Beta, 1.8.2-EE-GA, 1.8.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      Individual users may create very large numbers of views, resulting in memory exhaustion on the server.

      A new limit has been added, configurable through com.icesoft.faces.concurrentViewLimit.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19405 Tue Oct 13 09:37:38 MDT 2009 ted.goddard viewCap added with a default of 20 (ICE-5006)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
        Ted Goddard created issue -
        Hide
        Ken Fyten added a comment -

        Can we change the config. param name to be more descriptive?

        Suggest: "com.icesoft.faces.activeViewLimit"

        Also, please add a description for the new config. param along the lines of the other params (http://www.icefaces.org/docs/v1_8_2/htmlguide/devguide/appendixB.html#1048527). Please explain or link to a reference around when views are created, destroyed so folks can understand the implications of this setting better.

        Show
        Ken Fyten added a comment - Can we change the config. param name to be more descriptive? Suggest: "com.icesoft.faces.activeViewLimit" Also, please add a description for the new config. param along the lines of the other params ( http://www.icefaces.org/docs/v1_8_2/htmlguide/devguide/appendixB.html#1048527 ). Please explain or link to a reference around when views are created, destroyed so folks can understand the implications of this setting better.
        Ken Fyten made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 1.8.3 [ 10211 ]
        Assignee Ted Goddard [ ted.goddard ]
        Hide
        Ted Goddard added a comment -

        How about

        com.icesoft.faces.concurrentViewLimit

        Default Value 20

        Specifies to the ICEfaces framework how many concurrent views (typically one per browser window or tab) are allowed per user. When the limit is exceeded, a RuntimeException is thrown.

        Show
        Ted Goddard added a comment - How about com.icesoft.faces.concurrentViewLimit Default Value 20 Specifies to the ICEfaces framework how many concurrent views (typically one per browser window or tab) are allowed per user. When the limit is exceeded, a RuntimeException is thrown.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19409 Wed Oct 14 13:25:49 MDT 2009 ted.goddard added logging and renamed to concurrentViewLimit (ICE-5006)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
        Hide
        Ted Goddard added a comment -

        The parameter has been renamed to "concurrentViewLimit". Additionally, a WARN log entry is now produced with the current view limit and the guilty sessionID.

        Show
        Ted Goddard added a comment - The parameter has been renamed to "concurrentViewLimit". Additionally, a WARN log entry is now produced with the current view limit and the guilty sessionID.
        Ted Goddard made changes -
        Salesforce Case []
        Description Individual users may create very large numbers of views, resulting in memory exhaustion on the server.

        A new limit has been added, configurable through com.icesoft.faces.viewCap.

        Individual users may create very large numbers of views, resulting in memory exhaustion on the server.

        A new limit has been added, configurable through com.icesoft.faces.concurrentViewLimit.

        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P2
        Ken Fyten made changes -
        Salesforce Case []
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Ken Fyten made changes -
        Salesforce Case []
        Affects [Documentation (User Guide, Ref. Guide, etc.)] [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19486 Wed Oct 21 15:21:36 MDT 2009 ken.fyten ICE-5006: Increase default concurrentViewLimit to 50 views, up from 20. This is to avoid any likely impact on existing deployments with legitimate use-cases that require a large number of open views per session.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
        Hide
        Ken Fyten added a comment -

        Increased default concurrentViewLimit to 50 views, up from 20. This is to avoid any likely impact on existing deployments with legitimate use-cases that require a large number of open views per session.

        Marking FIXED.

        Show
        Ken Fyten added a comment - Increased default concurrentViewLimit to 50 views, up from 20. This is to avoid any likely impact on existing deployments with legitimate use-cases that require a large number of open views per session. Marking FIXED.
        Ken Fyten made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Priority P2
        Resolution Fixed [ 1 ]
        Assignee Ted Goddard [ ted.goddard ]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-Beta [ 10215 ]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-GA [ 10216 ]
        Ken Fyten made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: