Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.2
-
Fix Version/s: 3.1
-
Component/s: Release
-
Labels:None
-
Environment:Maven2
-
Assignee Priority:P1
-
ICEsoft Forum Reference:
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration
Description
It would be beneficial to add the ICEfaces source code and JavaDoc to the public Maven2 repository distributions.
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [5007000000A77e8] |
| Attachment | build-script-sources.patch [ 12060 ] |
Addition comment:
Please note: I discovered myself that when deploying the files in this sequence
mvn deploy:deploy-file <artifact file>
mvn deploy:deploy-file <source JAR>
I needed to use the -DgeneratePom=false option for the second command (the command that deploys the Source jar). Otherwise, the original POM file gets replaced, losing any dependency delcarations the original POM might have had. Which makes subsequent compiles fail. 
Show
Arran Mccullough
added a comment - Addition comment:
Please note: I discovered myself that when deploying the files in this sequence
mvn deploy:deploy-file <artifact file>
mvn deploy:deploy-file <source JAR>
I needed to use the -DgeneratePom=false option for the second command (the command that deploys the Source jar). Otherwise, the original POM file gets replaced, losing any dependency delcarations the original POM might have had. Which makes subsequent compiles fail.
| Fix Version/s | 1.8.3 [ 10211 ] |
| Fix Version/s | EE-2.1.0 [ 10262 ] | |
| Fix Version/s | 1.8.3 [ 10211 ] |
| Salesforce Case | [5007000000A77e8] | [5007000000A77e8, 5007000000Gv9Wk] |
| Link | This issue blocks ICE-6713 [ ICE-6713 ] |
| Fix Version/s | 3.1 [ 10312 ] | |
| Fix Version/s | EE-3.0.0.GA [ 10262 ] |
| Assignee | Deryk Sinotte [ deryk.sinotte ] |
| Fix Version/s | 3.1.0.BETA2 [ 10336 ] | |
| Assignee Priority | P2 |
| Fix Version/s | 3.1.0.RC1 [ 10337 ] | |
| Fix Version/s | 3.1.0.BETA2 [ 10336 ] |
| Issue Type | Improvement [ 4 ] | New Feature [ 2 ] |
| Fix Version/s | 3.1.0.RC1 [ 10337 ] | |
| Affects | [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration] | |
| Assignee Priority | P2 | P1 |
Resolving as fixed. The improvements done through ICE-8230 include adding source and javadoc jars for all the sub-projects except ICEpush.
Show
Deryk Sinotte
added a comment - Resolving as fixed. The improvements done through ICE-8230 include adding source and javadoc jars for all the sub-projects except ICEpush.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Contribution from ehillman:
For your consideration, I've attached a patch to the core and component
build.xml scripts that create a jar file (each) that contains their source
code. These get build to each dist directory.
Then these files can be deployed along with their appropriate artifact using
the mvn deploy:deploy-file command, being sure to use the classifier option.
For example, I can run the following from a command line...
ant -f $ICEFACES_SRC_DIR/core/build.xml sources-jar
mvn deploy:deploy-file
-Dfile=$ICEFACES_SRC_DIR/core/dist/icefaces-sources.jar
-DgroupId=org.icefaces -DartifactId=icefaces -Dversion=$ICEFACES_VERSION \
-Dclassifier=sources -Dpackaging=jar -Durl=$REPOSITORY_URL
-DrepositoryId=$REPOSITORY_ID
If ICEfaces deployed the source files for each artifact as well, I believe
it will be valued by the maven community using your artifacts.
Thanks,
Ed