ICEfaces
  1. ICEfaces
  2. ICE-4859

stateSavingMarker should not be visible

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.1
    • Fix Version/s: 1.8.2
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      current icefaces 1.8.1 from trunk

      Description

      Updates for form sends invalid content for empty form.

      In IE6-7 browsers empty forms (for example after modal popup is closed) are displayed with one line of empty area
      - this area should not be visible/

      Example of empty form after inner modal is closed

      <FORM class="iceFrm" id="ts3" onsubmit="return false;" action="javascript:;" method="post" class="iceFrm" enctype="application/x-www-form-urlencoded">
      <INPUT type="hidden" name="ts3" value="ts3" /><INPUT type="hidden" name="icefacesCssUpdates" value="" />
      <DIV id="ts3:stateSavingMarker">
        <INPUT id="javax.faces.ViewState" type="hidden" name="javax.faces.ViewState" value="1" />
        <INPUT type="hidden" name="javax.faces.RenderKitId" value="ICEfacesRenderKit" />
      </DIV>
      <DIV id="ts3hdnFldsDiv" style="DISPLAY: none"></DIV>
      </FORM>

      As you see div id="ts3:stateSavingMarker" should also got style="DISPLAY: none"


      Patch for FormRendered.java
      line 390
                  root.appendChild( n );
                  ((Element) n).setAttribute( "id", id );
      > ((Element) n).setAttribute(HTML.STYLE_ATTR, "display:none;");
                  domWriter.trackMarkerNode( n );
      1. err2.PNG
        18 kB
      2. screenshot-1.png
        164 kB

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19302 Fri Sep 25 09:57:05 MDT 2009 yip.ng ICE-4859: Specified zero width and height for state saving marker to make sure it doesn't display an empty form. (Suggested by Krashan Brahmanjara.)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java

          People

          • Assignee:
            yip.ng
            Reporter:
            Krashan Brahmanjara
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: