Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2-EE-Beta
    • Fix Version/s: 2.0-Beta2, 2.0.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces

      Description


      It's important to have clear distinction between classes that are intended for application developers to use and those that are not. ICEfaces 2.0 packaging should be reviewed with this (and other technical considerations) in mind.

        Issue Links

          Activity

          Ted Goddard created issue -
          Hide
          Ted Goddard added a comment -

          Packaging review can be discussed within this JIRA. For instance org/icefaces/push/Configuration.java is not specific to push and is not an application-developer class. Since we do not have the java.lang.* and com.sun.* separation common to Java (all classes for ICEfaces 2.0 belong to org.icefaces) we may wish to create org.icefaces.impl.* to indicate classes that are not of interest to application developers. Other strategies from existing open source projects should be included here.

          Show
          Ted Goddard added a comment - Packaging review can be discussed within this JIRA. For instance org/icefaces/push/Configuration.java is not specific to push and is not an application-developer class. Since we do not have the java.lang.* and com.sun.* separation common to Java (all classes for ICEfaces 2.0 belong to org.icefaces) we may wish to create org.icefaces.impl.* to indicate classes that are not of interest to application developers. Other strategies from existing open source projects should be included here.
          Ted Goddard made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s 2.0 [ 10032 ]
          Assignee Deryk Sinotte [ deryk.sinotte ]
          Ken Fyten made changes -
          Fix Version/s 2.0-Alpha1 [ 10213 ]
          Fix Version/s 2.0-Beta [ 10032 ]
          Affects Version/s 2.0-Alpha1 [ 10213 ]
          Affects Version/s 2.0-Beta [ 10032 ]
          Ken Fyten made changes -
          Fix Version/s 2.0-Alpha2 [ 10214 ]
          Fix Version/s 2.0-Alpha1 [ 10213 ]
          Ken Fyten made changes -
          Salesforce Case []
          Affects Version/s 1.8.2-EE-Beta [ 10215 ]
          Affects Version/s 2.0-Alpha1 [ 10213 ]
          Ken Fyten made changes -
          Salesforce Case []
          Fix Version/s 2.0-Beta [ 10032 ]
          Fix Version/s 2.0-Alpha2 [ 10214 ]
          Ken Fyten made changes -
          Fix Version/s 2.0-Beta [ 10231 ]
          Fix Version/s 2.0-Alpha3 [ 10032 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-4423 [ ICE-4423 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-4422 [ ICE-4422 ]
          Hide
          Ken Fyten added a comment -

          Suggestion to isolate non-public classes/APIs under a single package.

          org.icefaces.impl
          org.icefaces.[public API classes go here in some reasonable tree]

          Show
          Ken Fyten added a comment - Suggestion to isolate non-public classes/APIs under a single package. org.icefaces.impl org.icefaces. [public API classes go here in some reasonable tree]
          Ken Fyten made changes -
          Link This issue depends on ICE-5599 [ ICE-5599 ]
          Ken Fyten made changes -
          Salesforce Case []
          Assignee Priority P3
          Deryk Sinotte made changes -
          Salesforce Case []
          Assignee Priority P3 P2
          Ken Fyten made changes -
          Fix Version/s 2.0-Beta2 [ 10242 ]
          Fix Version/s 2.0-Beta1 [ 10231 ]
          Hide
          Deryk Sinotte added a comment - - edited

          From the core team status meeting and email threads on this topic, we've agreed to the following steps and changes:

          1) prune unnecessary/unused classes from the framework (see work related to ICE-5787)
          2) re-organize classes so that

          • public APIs are under org.icefaces.application which matches how JSF does it
          • non-public APIS are under org.icefaces.impl

          Initial re-packaging analysis:

          Good package, looking at renaming to ResourceRegistry. We have multiple paths of resource handling so we should rationalize this to a single path if possible.
          org/icefaces/application/DynamicResourceRegistry$Locator.class
          org/icefaces/application/DynamicResourceRegistry.class

          Move to org.icefaces.impl.* as an initial step. Replaced by the EnvUtils/EnvConfig classes and removed eventually
          org/icefaces/application/ExternalContextConfiguration.class

          Move to org.icefaces.impl.*
          org/icefaces/application/LazyPushManager$1.class
          org/icefaces/application/LazyPushManager$State.class
          org/icefaces/application/LazyPushManager.class

          Good package:
          org/icefaces/application/PortableRenderer.class
          org/icefaces/application/ProductInfo.class
          org/icefaces/application/PushRenderer$1.class
          org/icefaces/application/PushRenderer$2.class
          org/icefaces/application/PushRenderer.class

          Good package. We have multiple paths of resource handling so we should rationalize this to a single path if possible.
          org/icefaces/application/ResourceRegistry.class
          org/icefaces/application/ResourceRegistryHolder.class

          Move to impl (application use of WindowScopeManager?):
          org/icefaces/application/WindowELResolver.class
          org/icefaces/application/WindowScopeManager$1.class
          org/icefaces/application/WindowScopeManager$ReadyObservable.class
          org/icefaces/application/WindowScopeManager$ScopeMap.class
          org/icefaces/application/WindowScopeManager$State.class
          org/icefaces/application/WindowScopeManager.class

          Move to impl.
          org/icefaces/context/BasicResponseWriter.class
          org/icefaces/context/DOMPartialRenderCallback.class
          org/icefaces/context/DOMPartialViewContext$1.class
          org/icefaces/context/DOMPartialViewContext$2.class
          org/icefaces/context/DOMPartialViewContext$3.class
          org/icefaces/context/DOMPartialViewContext.class
          org/icefaces/context/DOMPartialViewContextFactory.class
          org/icefaces/context/DOMResponseWriter.class

          Move to impl. The event package is not my favourite name here as most of these are listeners and we're not really emitting any events but that's just minor semantics. We do need to go through and rationalize/factor/measure/optimize this list at some point as there's likely some common things being done. This is covered in ICE-5737.
          org/icefaces/event/AjaxDisabledList.class
          org/icefaces/event/AjaxDisabledWriter.class
          org/icefaces/event/BridgeSetup$1.class
          org/icefaces/event/BridgeSetup$2.class
          org/icefaces/event/BridgeSetup$3.class
          org/icefaces/event/BridgeSetup$4.class
          org/icefaces/event/BridgeSetup$JavascriptResourceOutput.class
          org/icefaces/event/BridgeSetup.class
          org/icefaces/event/DebugTagListener.class
          org/icefaces/event/DeltaSubmitPhaseListener$DeltaActionPortletRequest.class
          org/icefaces/event/DeltaSubmitPhaseListener$DeltaHttpServletRequest.class
          org/icefaces/event/DeltaSubmitPhaseListener.class
          org/icefaces/event/FormSubmit$1.class
          org/icefaces/event/FormSubmit.class
          org/icefaces/event/HeadBodyListener.class
          org/icefaces/event/JSFViewStateNavigationFix$1.class
          org/icefaces/event/JSFViewStateNavigationFix.class
          org/icefaces/event/MainEventListener.class
          org/icefaces/event/ScriptWriter.class
          org/icefaces/event/UIOutputWriter.class
          org/icefaces/event/WindowAndViewIDSetup$1.class
          org/icefaces/event/WindowAndViewIDSetup.class
          org/icefaces/event/WindowScopeSetup.class

          Move to impl for now. This class is a workaround for a problem with JSF standard messages renderer and should be removed when a fix is available.
          org/icefaces/faces/renderkit/html_basic/MessagesRenderer.class

          Move to impl for now. All configuration related changes should be ported to use EnvUtils where appropriate.
          org/icefaces/push/Configuration.class
          org/icefaces/push/ConfigurationException.class

          Move to impl for now. Many of these classes likely not necessary as they were used in ICEfaces 1.8 to virtualize Request/Response artifacts when doing Ajax Push. Now that Push has been re-designed, the virtualization is no longer necessary (see ICE-5787).
          org/icefaces/push/CurrentContext.class
          org/icefaces/push/DisposeWindowScope.class
          org/icefaces/push/DynamicResourceDispatcher$1.class
          org/icefaces/push/DynamicResourceDispatcher$ExtendedResourceOptions.class
          org/icefaces/push/DynamicResourceDispatcher$FileNameOption.class
          org/icefaces/push/DynamicResourceDispatcher$Mapping.class
          org/icefaces/push/DynamicResourceDispatcher$RelativeResourceLinker.class
          org/icefaces/push/DynamicResourceDispatcher$ResourceServer$1.class
          org/icefaces/push/DynamicResourceDispatcher$ResourceServer$ResourceOptions.class
          org/icefaces/push/DynamicResourceDispatcher$ResourceServer.class
          org/icefaces/push/DynamicResourceDispatcher.class
          org/icefaces/push/SessionBoundServer$1.class
          org/icefaces/push/SessionBoundServer$2.class
          org/icefaces/push/SessionBoundServer.class
          org/icefaces/push/SessionViewManager$1.class
          org/icefaces/push/SessionViewManager$State.class
          org/icefaces/push/SessionViewManager.class
          org/icefaces/push/http/AbstractServer.class
          org/icefaces/push/http/DynamicResource$Options.class
          org/icefaces/push/http/DynamicResource.class
          org/icefaces/push/http/DynamicResourceLinker$Handler.class
          org/icefaces/push/http/DynamicResourceLinker.class
          org/icefaces/push/http/MimeTypeMatcher.class
          org/icefaces/push/http/Request$Environment.class
          org/icefaces/push/http/Request.class
          org/icefaces/push/http/RequestProxy.class
          org/icefaces/push/http/Response.class
          org/icefaces/push/http/ResponseHandler.class
          org/icefaces/push/http/ResponseProxy.class
          org/icefaces/push/http/Server.class
          org/icefaces/push/http/ServerProxy.class
          org/icefaces/push/http/standard/CacheControlledServer$EnhancedRequest$1.class
          org/icefaces/push/http/standard/CacheControlledServer$EnhancedRequest.class
          org/icefaces/push/http/standard/CacheControlledServer.class
          org/icefaces/push/http/standard/CompressingServer$CompressingRequest$1.class
          org/icefaces/push/http/standard/CompressingServer$CompressingRequest.class
          org/icefaces/push/http/standard/CompressingServer$CompressingResponse.class
          org/icefaces/push/http/standard/CompressingServer.class
          org/icefaces/push/http/standard/EmptyResponse$1.class
          org/icefaces/push/http/standard/EmptyResponse.class
          org/icefaces/push/http/standard/FixedSizeContentHandler.class
          org/icefaces/push/http/standard/FixedXMLContentHandler.class
          org/icefaces/push/http/standard/NoCacheContentHandler.class
          org/icefaces/push/http/standard/NotFoundHandler.class
          org/icefaces/push/http/standard/NotModifiedHandler.class
          org/icefaces/push/http/standard/OKHandler.class
          org/icefaces/push/http/standard/OKResponse.class
          org/icefaces/push/http/standard/PathDispatcherServer.class
          org/icefaces/push/http/standard/ResponseHandlerServer.class
          org/icefaces/push/http/standard/StreamingContentHandler.class
          org/icefaces/push/http/standard/StringContentHandler.class
          org/icefaces/push/servlet/BasicAdaptingServlet.class
          org/icefaces/push/servlet/ICEfacesResourceHandler$1.class
          org/icefaces/push/servlet/ICEfacesResourceHandler$2.class
          org/icefaces/push/servlet/ICEfacesResourceHandler.class
          org/icefaces/push/servlet/ICEpushResourceHandler.class
          org/icefaces/push/servlet/PathDispatcher.class
          org/icefaces/push/servlet/ProxyHttpSession.class
          org/icefaces/push/servlet/PseudoServlet.class
          org/icefaces/push/servlet/ServletContextConfiguration.class
          org/icefaces/push/servlet/ServletEnvironmentListener.class
          org/icefaces/push/servlet/ServletRequestResponse.class
          org/icefaces/push/servlet/SessionDispatcher$1.class
          org/icefaces/push/servlet/SessionDispatcher$Monitor.class
          org/icefaces/push/servlet/SessionDispatcher.class
          org/icefaces/push/servlet/SessionExpiredException.class

          Move to impl. Consider mirroring Sun's package structure when we implement stuff like this (com.sun.faces.renderkit = org.icefaces.renderkit).
          org/icefaces/render/DOMRenderKit.class

          Move to impl.
          org/icefaces/util/Base64.class
          org/icefaces/util/CoreUtils.class
          org/icefaces/util/DOMUtils.class
          org/icefaces/util/EnvConfig.class

          Good package:
          org/icefaces/util/EnvUtils.class

          Show
          Deryk Sinotte added a comment - - edited From the core team status meeting and email threads on this topic, we've agreed to the following steps and changes: 1) prune unnecessary/unused classes from the framework (see work related to ICE-5787 ) 2) re-organize classes so that public APIs are under org.icefaces.application which matches how JSF does it non-public APIS are under org.icefaces.impl Initial re-packaging analysis: Good package, looking at renaming to ResourceRegistry. We have multiple paths of resource handling so we should rationalize this to a single path if possible. org/icefaces/application/DynamicResourceRegistry$Locator.class org/icefaces/application/DynamicResourceRegistry.class Move to org.icefaces.impl.* as an initial step. Replaced by the EnvUtils/EnvConfig classes and removed eventually org/icefaces/application/ExternalContextConfiguration.class Move to org.icefaces.impl.* org/icefaces/application/LazyPushManager$1.class org/icefaces/application/LazyPushManager$State.class org/icefaces/application/LazyPushManager.class Good package: org/icefaces/application/PortableRenderer.class org/icefaces/application/ProductInfo.class org/icefaces/application/PushRenderer$1.class org/icefaces/application/PushRenderer$2.class org/icefaces/application/PushRenderer.class Good package. We have multiple paths of resource handling so we should rationalize this to a single path if possible. org/icefaces/application/ResourceRegistry.class org/icefaces/application/ResourceRegistryHolder.class Move to impl (application use of WindowScopeManager?): org/icefaces/application/WindowELResolver.class org/icefaces/application/WindowScopeManager$1.class org/icefaces/application/WindowScopeManager$ReadyObservable.class org/icefaces/application/WindowScopeManager$ScopeMap.class org/icefaces/application/WindowScopeManager$State.class org/icefaces/application/WindowScopeManager.class Move to impl. org/icefaces/context/BasicResponseWriter.class org/icefaces/context/DOMPartialRenderCallback.class org/icefaces/context/DOMPartialViewContext$1.class org/icefaces/context/DOMPartialViewContext$2.class org/icefaces/context/DOMPartialViewContext$3.class org/icefaces/context/DOMPartialViewContext.class org/icefaces/context/DOMPartialViewContextFactory.class org/icefaces/context/DOMResponseWriter.class Move to impl. The event package is not my favourite name here as most of these are listeners and we're not really emitting any events but that's just minor semantics. We do need to go through and rationalize/factor/measure/optimize this list at some point as there's likely some common things being done. This is covered in ICE-5737 . org/icefaces/event/AjaxDisabledList.class org/icefaces/event/AjaxDisabledWriter.class org/icefaces/event/BridgeSetup$1.class org/icefaces/event/BridgeSetup$2.class org/icefaces/event/BridgeSetup$3.class org/icefaces/event/BridgeSetup$4.class org/icefaces/event/BridgeSetup$JavascriptResourceOutput.class org/icefaces/event/BridgeSetup.class org/icefaces/event/DebugTagListener.class org/icefaces/event/DeltaSubmitPhaseListener$DeltaActionPortletRequest.class org/icefaces/event/DeltaSubmitPhaseListener$DeltaHttpServletRequest.class org/icefaces/event/DeltaSubmitPhaseListener.class org/icefaces/event/FormSubmit$1.class org/icefaces/event/FormSubmit.class org/icefaces/event/HeadBodyListener.class org/icefaces/event/JSFViewStateNavigationFix$1.class org/icefaces/event/JSFViewStateNavigationFix.class org/icefaces/event/MainEventListener.class org/icefaces/event/ScriptWriter.class org/icefaces/event/UIOutputWriter.class org/icefaces/event/WindowAndViewIDSetup$1.class org/icefaces/event/WindowAndViewIDSetup.class org/icefaces/event/WindowScopeSetup.class Move to impl for now. This class is a workaround for a problem with JSF standard messages renderer and should be removed when a fix is available. org/icefaces/faces/renderkit/html_basic/MessagesRenderer.class Move to impl for now. All configuration related changes should be ported to use EnvUtils where appropriate. org/icefaces/push/Configuration.class org/icefaces/push/ConfigurationException.class Move to impl for now. Many of these classes likely not necessary as they were used in ICEfaces 1.8 to virtualize Request/Response artifacts when doing Ajax Push. Now that Push has been re-designed, the virtualization is no longer necessary (see ICE-5787 ). org/icefaces/push/CurrentContext.class org/icefaces/push/DisposeWindowScope.class org/icefaces/push/DynamicResourceDispatcher$1.class org/icefaces/push/DynamicResourceDispatcher$ExtendedResourceOptions.class org/icefaces/push/DynamicResourceDispatcher$FileNameOption.class org/icefaces/push/DynamicResourceDispatcher$Mapping.class org/icefaces/push/DynamicResourceDispatcher$RelativeResourceLinker.class org/icefaces/push/DynamicResourceDispatcher$ResourceServer$1.class org/icefaces/push/DynamicResourceDispatcher$ResourceServer$ResourceOptions.class org/icefaces/push/DynamicResourceDispatcher$ResourceServer.class org/icefaces/push/DynamicResourceDispatcher.class org/icefaces/push/SessionBoundServer$1.class org/icefaces/push/SessionBoundServer$2.class org/icefaces/push/SessionBoundServer.class org/icefaces/push/SessionViewManager$1.class org/icefaces/push/SessionViewManager$State.class org/icefaces/push/SessionViewManager.class org/icefaces/push/http/AbstractServer.class org/icefaces/push/http/DynamicResource$Options.class org/icefaces/push/http/DynamicResource.class org/icefaces/push/http/DynamicResourceLinker$Handler.class org/icefaces/push/http/DynamicResourceLinker.class org/icefaces/push/http/MimeTypeMatcher.class org/icefaces/push/http/Request$Environment.class org/icefaces/push/http/Request.class org/icefaces/push/http/RequestProxy.class org/icefaces/push/http/Response.class org/icefaces/push/http/ResponseHandler.class org/icefaces/push/http/ResponseProxy.class org/icefaces/push/http/Server.class org/icefaces/push/http/ServerProxy.class org/icefaces/push/http/standard/CacheControlledServer$EnhancedRequest$1.class org/icefaces/push/http/standard/CacheControlledServer$EnhancedRequest.class org/icefaces/push/http/standard/CacheControlledServer.class org/icefaces/push/http/standard/CompressingServer$CompressingRequest$1.class org/icefaces/push/http/standard/CompressingServer$CompressingRequest.class org/icefaces/push/http/standard/CompressingServer$CompressingResponse.class org/icefaces/push/http/standard/CompressingServer.class org/icefaces/push/http/standard/EmptyResponse$1.class org/icefaces/push/http/standard/EmptyResponse.class org/icefaces/push/http/standard/FixedSizeContentHandler.class org/icefaces/push/http/standard/FixedXMLContentHandler.class org/icefaces/push/http/standard/NoCacheContentHandler.class org/icefaces/push/http/standard/NotFoundHandler.class org/icefaces/push/http/standard/NotModifiedHandler.class org/icefaces/push/http/standard/OKHandler.class org/icefaces/push/http/standard/OKResponse.class org/icefaces/push/http/standard/PathDispatcherServer.class org/icefaces/push/http/standard/ResponseHandlerServer.class org/icefaces/push/http/standard/StreamingContentHandler.class org/icefaces/push/http/standard/StringContentHandler.class org/icefaces/push/servlet/BasicAdaptingServlet.class org/icefaces/push/servlet/ICEfacesResourceHandler$1.class org/icefaces/push/servlet/ICEfacesResourceHandler$2.class org/icefaces/push/servlet/ICEfacesResourceHandler.class org/icefaces/push/servlet/ICEpushResourceHandler.class org/icefaces/push/servlet/PathDispatcher.class org/icefaces/push/servlet/ProxyHttpSession.class org/icefaces/push/servlet/PseudoServlet.class org/icefaces/push/servlet/ServletContextConfiguration.class org/icefaces/push/servlet/ServletEnvironmentListener.class org/icefaces/push/servlet/ServletRequestResponse.class org/icefaces/push/servlet/SessionDispatcher$1.class org/icefaces/push/servlet/SessionDispatcher$Monitor.class org/icefaces/push/servlet/SessionDispatcher.class org/icefaces/push/servlet/SessionExpiredException.class Move to impl. Consider mirroring Sun's package structure when we implement stuff like this (com.sun.faces.renderkit = org.icefaces.renderkit). org/icefaces/render/DOMRenderKit.class Move to impl. org/icefaces/util/Base64.class org/icefaces/util/CoreUtils.class org/icefaces/util/DOMUtils.class org/icefaces/util/EnvConfig.class Good package: org/icefaces/util/EnvUtils.class
          Hide
          Deryk Sinotte added a comment -

          Working on pruning unused classes and then testing should proceed before we do the repackaging.

          Show
          Deryk Sinotte added a comment - Working on pruning unused classes and then testing should proceed before we do the repackaging.
          Deryk Sinotte made changes -
          Link This issue depends on ICE-5787 [ ICE-5787 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22359 Thu Sep 16 13:05:55 MDT 2010 deryk.sinotte ICE-4796: Re-packaging of org.icefaces.* to separate public api and implementation classes
          Files Changed
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/CurrentContext.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContextFactory.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/JSFViewStateNavigationFix.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/WindowAndViewIDSetup.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/test/java/org/icefaces/domDiff/DomDiffTest.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FormSubmit.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/FormEndRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/http/DynamicResource.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/inputfile/InputFile.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/WindowAndViewIDSetup.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/DOMPartialViewContextFactory.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/UIOutputWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/EnvConfig.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/BridgeSetup.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/Configuration.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/DynamicResourceRegistry.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/BasicResponseWriter.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/TextRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/html_basic/MessagesRenderer.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/LazyPushManager.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces
          Commit graph MODIFY /icefaces2/trunk/icefaces/samples/test/invalidate/src/main/webapp/WEB-INF/web.xml
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/WindowScopeManager.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/http/DynamicResourceLinker.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/Configuration.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/ExternalContextConfiguration.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/CoreUtils.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/DOMUtils.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/DebugTagListener.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/Base64.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces/core/ConfigHandler.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/MainEventListener.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag/icefaces/core
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/FormEndRendering.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/resources/META-INF/core.taglib.xml
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/DeltaSubmitPhaseListener.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/html_basic
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/SessionExpiredListener.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/outputprogress/OutputProgress.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/OutputTextRenderer.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/http/DynamicResource.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/SessionViewManager.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/DOMUtils.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/HeadBodyListener.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/DynamicResourceRegistry.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ProxyHttpServletResponse.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/FacesMessagesPhaseListener.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/AjaxDisabledList.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/ResourceRegistry.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/facelets/tag/icefaces/core/ConfigHandler.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/CurrentContext.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/FormEndRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/Base64.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/BridgeSetup.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/DOMRenderKit.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/CompatDOMPartialViewContext.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/FormEndRendering.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/ScriptWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/MainEventListener.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/http/DynamicResourceLinker.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/ConfigurationException.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/TextareaRenderer.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/samples/test/invalidate/src/main/java/org/icefaces/test/invalidate/TestBean.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/servlet/ICEpushResourceHandler.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/RendererWrapper.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/test/java/org/icefaces/context/DOMResponseWriterTest.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/WindowELResolver.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/ConfigurationException.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/ResourceRegistryLocator.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/AjaxDisabledList.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvConfig.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/SessionExpiredListener.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/facelets/tag
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/LazyPushManager.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/BasicResponseWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FacesMessagesPhaseListener.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/WindowScopeManager.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/application/ExternalContextConfiguration.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/CompatResourceWrapper.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menubar/MenuItemRenderer.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/DebugTagListener.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/util/JavaScriptRunnerSetup.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ProxyHttpServletRequest.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/component/JavaScriptContextSetup.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/HeadBodyListener.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/FormSubmit.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/util/CoreUtils.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/DeltaSubmitPhaseListener.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/OutputMessageRenderer.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/context/DOMContext.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/SessionViewManager.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/JSFViewStateNavigationFix.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/SessionExpiredException.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/event/UIOutputWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/renderkit/DOMRenderKit.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/servlet/ProxyHttpServletResponse.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/WindowELResolver.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/DynamicResourceDispatcher.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/DOMPartialViewContext.java
          Commit graph MODIFY /icefaces2/trunk/icefaces/core/src/main/resources/META-INF/faces-config.xml
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/render/RendererWrapper.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context/SessionExpiredException.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/DynamicResourceDispatcher.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/ScriptWriter.java
          Commit graph ADD /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/http
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/push/servlet/ProxyHttpServletRequest.java
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/faces/renderkit/html_basic/MessagesRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #22360 Thu Sep 16 13:12:31 MDT 2010 deryk.sinotte ICE-4796: remove old impl directories for packages that are now empty
          Files Changed
          Commit graph DEL /icefaces2/trunk/icefaces/core/src/main/java/org/icefaces/context
          Hide
          Deryk Sinotte added a comment -

          As outlined in the detailed analysis, the packaging adjustment has been completed.

          Show
          Deryk Sinotte added a comment - As outlined in the detailed analysis, the packaging adjustment has been completed.
          Deryk Sinotte made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 2.0.0 [ 10230 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P2

            People

            • Assignee:
              Deryk Sinotte
              Reporter:
              Ted Goddard
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: