ICEfaces
  1. ICEfaces
  2. ICE-4770

dispose-views and rendering mutual exclusion

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description


            A dispose-views request can occur at nearly the same time as a push request or a user event. This can lead to a race condition where the view is disposed while being rendered.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19118 Fri Jul 24 16:33:13 MDT 2009 ted.goddard acquire lock for view disposal (ICE-4770)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/DisposeViews.java
              Ted Goddard created issue -
              Hide
              Permalink
              Ted Goddard added a comment -

              Tested fix was to add synchronization to view disposal.

              +++ src/com/icesoft/faces/webapp/http/core/DisposeViews.java (working copy)
              @@ -26,7 +26,9 @@
              View view = (View) views.remove(viewIdentifiers[i]);
              // Jira 1616 Logout throws NPE.
              if (view != null)

              { + view.acquireLifecycleLock(); view.dispose(); + view.releaseLifecycleLock(); }

              }

              Show
              Ted Goddard added a comment - Tested fix was to add synchronization to view disposal. +++ src/com/icesoft/faces/webapp/http/core/DisposeViews.java (working copy) @@ -26,7 +26,9 @@ View view = (View) views.remove(viewIdentifiers [i] ); // Jira 1616 Logout throws NPE. if (view != null) { + view.acquireLifecycleLock(); view.dispose(); + view.releaseLifecycleLock(); } }
              Hide
              Permalink
              Ted Goddard added a comment -

              Please review the change (revision 19118) and close or modify. Race condition is reproducible under load.

              The load test may issue a send-receive-updates which is context-switched out when a dispose-views is received and processed. When the send-receive-updates wakes up again, the viewRoot is null.

              Under real-world conditions, a more likely case is a dispose-views coinciding with a push update.

              Show
              Ted Goddard added a comment - Please review the change (revision 19118) and close or modify. Race condition is reproducible under load. The load test may issue a send-receive-updates which is context-switched out when a dispose-views is received and processed. When the send-receive-updates wakes up again, the viewRoot is null. Under real-world conditions, a more likely case is a dispose-views coinciding with a push update.
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Ted Goddard made changes -
              Salesforce Case []
              Fix Version/s 1.8.2 [ 10190 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19127 Tue Jul 28 17:17:04 MDT 2009 mircea.toma ICE-4770 Use try/finally construct to make sure JSF lifecycle lock is always released.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/DisposeViews.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Use try/finally construct to make sure JSF lifecycle lock is always released.

              Show
              Mircea Toma added a comment - Use try/finally construct to make sure JSF lifecycle lock is always released.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19133 Thu Jul 30 15:59:32 MDT 2009 mircea.toma ICE-4770 Internalize View's lock handling.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/DisposeViews.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
              Mircea Toma made changes -
              Link This issue blocks ICE-4756 [ ICE-4756 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2-RC1 [ 10210 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: