ICEfaces
  1. ICEfaces
  2. ICE-4712

dataTable get data models less redundantly

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 1.8.1
    • Fix Version/s: 1.8.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      The h: and ice: dataTable renderers could be optimised to get the row and ice:columns data models less frequently in a given render operation. The row data model need only be gotten once, while anycolumn data model may need to be gotten once per row, but definitely not once per cell.

      For a large dataTable, these costs can add up to a noticeable amount of wasted processing time.

      This is a similar concept to: ICE-3721.

        Activity

        Mark Collette created issue -
        Mark Collette made changes -
        Field Original Value New Value
        Salesforce Case []
        Description The h: and ice: dataTable renderers could be optimised to get the row and ice:columns data models less frequently in a given render operation. The row data model need only be gotten once, while anycolumn data model may need to be gotten once per row, but definitely not once per cell.

        For a large dataTable, these costs can add up to a noticeable amount of wasted processing time.
        The h: and ice: dataTable renderers could be optimised to get the row and ice:columns data models less frequently in a given render operation. The row data model need only be gotten once, while anycolumn data model may need to be gotten once per row, but definitely not once per cell.

        For a large dataTable, these costs can add up to a noticeable amount of wasted processing time.

        This is a similar concept to: ICE-3721.
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s 1.8.2 [ 10190 ]
        Assignee Priority P3
        Assignee Mark Collette [ mark.collette ]
        Tyler Johnson made changes -
        Salesforce Case [50070000008oymM]
        Hide
        Mark Collette added a comment -

        After going through the dataTable code, I wasn't finding any gross abuses of regetting the datamodels, so I asked Tyler to link in the original Salesforce, so I could read the customer's comments. Turns out the issue is not about the datatable at all, but just how JSF EL lazy evaluation doesn't work as optimally as people would hope. It re-queries every time, and never caches.

        Show
        Mark Collette added a comment - After going through the dataTable code, I wasn't finding any gross abuses of regetting the datamodels, so I asked Tyler to link in the original Salesforce, so I could read the customer's comments. Turns out the issue is not about the datatable at all, but just how JSF EL lazy evaluation doesn't work as optimally as people would hope. It re-queries every time, and never caches.
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Invalid [ 6 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P3

          People

          • Assignee:
            Mark Collette
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: