Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8
-
Component/s: ICE-Components
-
Labels:None
-
Environment:All
-
Workaround Exists:Yes
-
Workaround Description:Ensure SelectItems are constructed with non null values.
Description
If the SelectItem constructer's label is null (SelectItem(java.lang.Object value, java.lang.String label)), ICEfaces will fail to render the SelectItem and will throw an exception. Here is the code required to reproduce the issue:
public class BackingBean {
private String selectedItem;
private SelectItem[] items = new SelectItem[]{
new SelectItem("value1","label1"),
new SelectItem("value2","label2"),
new SelectItem("value3",null),
new SelectItem("value4","label4")
};
........
main.jspx
<ice:selectOneMenu id="SlctCompTyp"
partialSubmit="true">
<f:selectItems id="SlctcompTypeItms"
value="#{backingBean.items}"/>
</ice:selectOneMenu>
........
will cause the following exception to be thrown:
16:21:06,926 WARN [lifecycle] executePhase(RENDER_RESPONSE 6,com.icesoft.faces.context.BridgeFacesContext@1e212d0) threw exception
java.lang.NullPointerException
at java.io.Writer.write(Unknown Source)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:182)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:168)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:168)
.....
The workaround would of course be to have non null values. It would be nice to not throw such a nasty exception and instead handle it a bit more gracefully.
public class BackingBean {
private String selectedItem;
private SelectItem[] items = new SelectItem[]{
new SelectItem("value1","label1"),
new SelectItem("value2","label2"),
new SelectItem("value3",null),
new SelectItem("value4","label4")
};
........
main.jspx
<ice:selectOneMenu id="SlctCompTyp"
partialSubmit="true">
<f:selectItems id="SlctcompTypeItms"
value="#{backingBean.items}"/>
</ice:selectOneMenu>
........
will cause the following exception to be thrown:
16:21:06,926 WARN [lifecycle] executePhase(RENDER_RESPONSE 6,com.icesoft.faces.context.BridgeFacesContext@1e212d0) threw exception
java.lang.NullPointerException
at java.io.Writer.write(Unknown Source)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:182)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:168)
at com.icesoft.faces.util.DOMUtils.printNode(DOMUtils.java:168)
.....
The workaround would of course be to have non null values. It would be nice to not throw such a nasty exception and instead handle it a bit more gracefully.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [500700000080czp, 50070000007BmrT] |
| Fix Version/s | 1.8.2 [ 10190 ] | |
| Assignee Priority | P3 | |
| Assignee | Mark Collette [ mark.collette ] |
| Assignee | Mark Collette [ mark.collette ] | Yip Ng [ yip.ng ] |
| Attachment | ScreenHunter_04.jpg [ 11816 ] |
Can't reproduce. See screenshot. If I used a null label, the label would show up as "null", but there would be no runtime exception. Will try to change the null to empty string anyway.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #19022 | Wed Jul 01 15:43:24 MDT 2009 | yip.ng | Changed to use the value of a select item as label if the label is null. |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java
|
1.1_02 (24 April 2006):
writer.writeText(curItem.getLabel(), "label");
1.2 (May 2006):
if (curItem.isEscape())
{ writer.writeText(curItem.getLabel(), "label"); }else
{ writer.write(curItem.getLabel()); }1.2_12 (16 Jan 2009):
if (curItem.isEscape()) {
String label = curItem.getLabel();
if (label == null) { label = valueString; }
writer.writeText(label, component, "label");
} else { writer.write(curItem.getLabel()); }
Show
yip.ng
added a comment - 1.1_02 (24 April 2006):
writer.writeText(curItem.getLabel(), "label");
1.2 (May 2006):
if (curItem.isEscape())
{
writer.writeText(curItem.getLabel(), "label");
}
else
{
writer.write(curItem.getLabel());
}
1.2_12 (16 Jan 2009):
if (curItem.isEscape()) {
String label = curItem.getLabel();
if (label == null) {
label = valueString;
}
writer.writeText(label, component, "label");
} else {
writer.write(curItem.getLabel());
}
Changed to use the value of a select item (i.e. value of <option>) as label if label is null. (There is no isEscape() in JSF 1.1.)
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Attachment | ScreenHunter_05.jpg [ 11817 ] |
| Fix Version/s | 1.8.2-RC1 [ 10210 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P3 |
Should compare our behavior to standard h: comp. Might be nice to convert nulls to "" to avoid this.