ICEfaces
  1. ICEfaces
  2. ICE-4539

UploadServer can fail with frameworks that rely on ThreadLocals

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: Framework, ICE-Components
          • Labels:
            None
          • Environment:
            spring file upload

            Description

            The UploadServer has logic where it uses a separate, non-JSF thread, to load the file content. We bypass this logic when another framework (e.g Seam, Spring Web Flow) is relying on ThreadLocals to do what they need to do. The check to ensure that the appropriate code path is selected is not very generic. It currently only supports Seam and Spring Web Flow. The forum user was using Spring Security and ran into problems using the file upload component. They were able to work around it by modifying the source code to also check for Spring Security. However, this strategy is a bit of a treadmill in that we'll always potentially be behind in adding checks for the next framework.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18992 Wed Jun 24 12:49:29 MDT 2009 greg.dick ICE-4539 Added 'force' to property name to indicate how it should be used.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18989 Wed Jun 24 09:25:57 MDT 2009 greg.dick ICE-4539 Added check for Spring security context
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/util/SeamUtilities.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18988 Wed Jun 24 09:24:39 MDT 2009 greg.dick ICE-4539 Added check for Spring security and a context parameter when deciding to execute JSF lifecycle in calling thread
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  3 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: